* [RFC PATCH 1/5] block/genhd: Notify udev about capacity change
@ 2019-12-23 1:40 Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Balbir Singh @ 2019-12-23 1:40 UTC (permalink / raw)
To: =linux-block, linux-kernel, linux-nvme
Cc: axboe, mst, jejb, ssomesh, Balbir Singh, hch
Allow block/genhd to notify user space (via udev) about disk size changes
using a new helper disk_set_capacity(), which is a wrapper on top
of set_capacity(). disk_set_capacity() will only notify via udev if
the current capacity or the target capacity is not zero.
Background:
As a part of a patch to allow sending the RESIZE event on disk capacity
change, Christoph (hch@lst.de) requested that the patch be made generic
and the hacks for virtio block and xen block devices be removed and
merged via a generic helper.
Testing:
1. I did some basic testing with an NVME device, by resizing it in
the backend and ensured that udevd received the event.
Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Balbir Singh <sblbir@amazon.com>
Signed-off-by: Someswarudu Sangaraju <ssomesh@amazon.com>
Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
block/genhd.c | 19 +++++++++++++++++++
include/linux/genhd.h | 1 +
2 files changed, 20 insertions(+)
diff --git a/block/genhd.c b/block/genhd.c
index ff6268970ddc..94faec98607b 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -46,6 +46,25 @@ static void disk_add_events(struct gendisk *disk);
static void disk_del_events(struct gendisk *disk);
static void disk_release_events(struct gendisk *disk);
+/*
+ * Set disk capacity and notify if the size is not currently
+ * zero and will not be set to zero
+ */
+void disk_set_capacity(struct gendisk *disk, sector_t size)
+{
+ sector_t capacity = get_capacity(disk);
+
+ set_capacity(disk, size);
+ if (capacity != 0 && size != 0) {
+ char *envp[] = { "RESIZE=1", NULL };
+
+ kobject_uevent_env(&disk_to_dev(disk)->kobj, KOBJ_CHANGE, envp);
+ }
+}
+
+EXPORT_SYMBOL_GPL(disk_set_capacity);
+
+
void part_inc_in_flight(struct request_queue *q, struct hd_struct *part, int rw)
{
if (queue_is_mq(q))
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index a927829bb73a..f1a5ddcc781d 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -449,6 +449,7 @@ static inline int get_disk_ro(struct gendisk *disk)
extern void disk_block_events(struct gendisk *disk);
extern void disk_unblock_events(struct gendisk *disk);
extern void disk_flush_events(struct gendisk *disk, unsigned int mask);
+extern void disk_set_capacity(struct gendisk *disk, sector_t size);
extern unsigned int disk_clear_events(struct gendisk *disk, unsigned int mask);
/* drivers/char/random.c */
--
2.16.5
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RFC PATCH 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity
2019-12-23 1:40 [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Balbir Singh
@ 2019-12-23 1:40 ` Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Balbir Singh @ 2019-12-23 1:40 UTC (permalink / raw)
To: =linux-block, linux-kernel, linux-nvme
Cc: axboe, mst, jejb, ssomesh, Balbir Singh, hch
block/genhd provides disk_set_capacity() for sending
RESIZE notifications via uevents.
Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
drivers/block/virtio_blk.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index fbbf18ac1d5d..9848c94a7eb4 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -479,18 +479,16 @@ static void virtblk_update_capacity(struct virtio_blk *vblk, bool resize)
cap_str_10,
cap_str_2);
- set_capacity(vblk->disk, capacity);
+ disk_set_capacity(vblk->disk, capacity);
}
static void virtblk_config_changed_work(struct work_struct *work)
{
struct virtio_blk *vblk =
container_of(work, struct virtio_blk, config_work);
- char *envp[] = { "RESIZE=1", NULL };
virtblk_update_capacity(vblk, true);
revalidate_disk(vblk->disk);
- kobject_uevent_env(&disk_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp);
}
static void virtblk_config_changed(struct virtio_device *vdev)
--
2.16.5
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RFC PATCH 3/5] drivers/block/xen-blkfront.c: Convert to use disk_set_capacity
2019-12-23 1:40 [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
@ 2019-12-23 1:40 ` Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 4/5] drivers/nvme/host/core.c: " Balbir Singh
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Balbir Singh @ 2019-12-23 1:40 UTC (permalink / raw)
To: =linux-block, linux-kernel, linux-nvme
Cc: axboe, mst, jejb, ssomesh, Balbir Singh, hch
block/genhd provides disk_set_capacity() for sending
RESIZE notifications via uevents.
Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
drivers/block/xen-blkfront.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 23c86350a5ab..bed7050a697d 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2337,7 +2337,6 @@ static void blkfront_connect(struct blkfront_info *info)
unsigned long sector_size;
unsigned int physical_sector_size;
unsigned int binfo;
- char *envp[] = { "RESIZE=1", NULL };
int err, i;
switch (info->connected) {
@@ -2352,10 +2351,8 @@ static void blkfront_connect(struct blkfront_info *info)
return;
printk(KERN_INFO "Setting capacity to %Lu\n",
sectors);
- set_capacity(info->gd, sectors);
+ disk_set_capacity(info->gd, sectors);
revalidate_disk(info->gd);
- kobject_uevent_env(&disk_to_dev(info->gd)->kobj,
- KOBJ_CHANGE, envp);
return;
case BLKIF_STATE_SUSPENDED:
--
2.16.5
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RFC PATCH 4/5] drivers/nvme/host/core.c: Convert to use disk_set_capacity
2019-12-23 1:40 [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
@ 2019-12-23 1:40 ` Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 5/5] drivers/scsi/sd.c: " Balbir Singh
2019-12-23 1:53 ` [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Singh, Balbir
4 siblings, 0 replies; 8+ messages in thread
From: Balbir Singh @ 2019-12-23 1:40 UTC (permalink / raw)
To: =linux-block, linux-kernel, linux-nvme
Cc: axboe, mst, jejb, ssomesh, Balbir Singh, hch
block/genhd provides disk_set_capacity() for sending
RESIZE notifications via uevents. This notification is
newly added to NVME devices
Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 667f18f465be..cb214e914fc2 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1808,7 +1808,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
ns->lba_shift > PAGE_SHIFT)
capacity = 0;
- set_capacity(disk, capacity);
+ disk_set_capacity(disk, capacity);
nvme_config_discard(disk, ns);
nvme_config_write_zeroes(disk, ns);
--
2.16.5
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RFC PATCH 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity
2019-12-23 1:40 [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Balbir Singh
` (2 preceding siblings ...)
2019-12-23 1:40 ` [RFC PATCH 4/5] drivers/nvme/host/core.c: " Balbir Singh
@ 2019-12-23 1:40 ` Balbir Singh
2019-12-23 1:53 ` [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Singh, Balbir
4 siblings, 0 replies; 8+ messages in thread
From: Balbir Singh @ 2019-12-23 1:40 UTC (permalink / raw)
To: =linux-block, linux-kernel, linux-nvme
Cc: axboe, mst, jejb, ssomesh, Balbir Singh, hch
block/genhd provides disk_set_capacity() for sending
RESIZE notifications via uevents. This notification is
newly added to scsi sd.
Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5afb0046b12a..1a3be30b6b78 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3184,7 +3184,7 @@ static int sd_revalidate_disk(struct gendisk *disk)
sdkp->first_scan = 0;
- set_capacity(disk, logical_to_sectors(sdp, sdkp->capacity));
+ disk_set_capacity(disk, logical_to_sectors(sdp, sdkp->capacity));
sd_config_write_same(sdkp);
kfree(buffer);
--
2.16.5
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFC PATCH 1/5] block/genhd: Notify udev about capacity change
2019-12-23 1:40 [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Balbir Singh
` (3 preceding siblings ...)
2019-12-23 1:40 ` [RFC PATCH 5/5] drivers/scsi/sd.c: " Balbir Singh
@ 2019-12-23 1:53 ` Singh, Balbir
2020-01-01 3:26 ` Chaitanya Kulkarni
4 siblings, 1 reply; 8+ messages in thread
From: Singh, Balbir @ 2019-12-23 1:53 UTC (permalink / raw)
To: linux-kernel, =linux-block, linux-nvme
Cc: axboe, Sangaraju, Someswarudu, jejb, hch, mst
On Mon, 2019-12-23 at 01:40 +0000, Balbir Singh wrote:
> Allow block/genhd to notify user space (via udev) about disk size changes
> using a new helper disk_set_capacity(), which is a wrapper on top
> of set_capacity(). disk_set_capacity() will only notify via udev if
> the current capacity or the target capacity is not zero.
>
> Background:
>
> As a part of a patch to allow sending the RESIZE event on disk capacity
> change, Christoph (hch@lst.de) requested that the patch be made generic
> and the hacks for virtio block and xen block devices be removed and
> merged via a generic helper.
>
>
I messed up with linux-block ML address, I can resend with the right address
if needed. My apologies
Balbir Singh.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH 1/5] block/genhd: Notify udev about capacity change
2019-12-23 1:53 ` [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Singh, Balbir
@ 2020-01-01 3:26 ` Chaitanya Kulkarni
2020-01-02 7:36 ` Singh, Balbir
0 siblings, 1 reply; 8+ messages in thread
From: Chaitanya Kulkarni @ 2020-01-01 3:26 UTC (permalink / raw)
To: Singh, Balbir, linux-kernel, =linux-block, linux-nvme
Cc: axboe, Sangaraju, Someswarudu, jejb, hch, mst
On 12/22/19 5:53 PM, Singh, Balbir wrote:
> I messed up with linux-block ML address, I can resend with the right address
> if needed. My apologies
>
> Balbir Singh.
Unless you have sent it already and I totally missed it,
if you are planning to resend can you please also add a cover-letter ?
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH 1/5] block/genhd: Notify udev about capacity change
2020-01-01 3:26 ` Chaitanya Kulkarni
@ 2020-01-02 7:36 ` Singh, Balbir
0 siblings, 0 replies; 8+ messages in thread
From: Singh, Balbir @ 2020-01-02 7:36 UTC (permalink / raw)
To: linux-kernel, Chaitanya.Kulkarni, =linux-block, linux-nvme
Cc: axboe, Sangaraju, Someswarudu, jejb, hch, mst
On Wed, 2020-01-01 at 03:26 +0000, Chaitanya Kulkarni wrote:
> On 12/22/19 5:53 PM, Singh, Balbir wrote:
> > I messed up with linux-block ML address, I can resend with the right
> > address
> > if needed. My apologies
> >
> > Balbir Singh.
>
>
> Unless you have sent it already and I totally missed it,
> if you are planning to resend can you please also add a cover-letter ?
I did not resend it, I'll resend and add a cover letter.
Balbir Singh.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-02 7:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 1:40 [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 4/5] drivers/nvme/host/core.c: " Balbir Singh
2019-12-23 1:40 ` [RFC PATCH 5/5] drivers/scsi/sd.c: " Balbir Singh
2019-12-23 1:53 ` [RFC PATCH 1/5] block/genhd: Notify udev about capacity change Singh, Balbir
2020-01-01 3:26 ` Chaitanya Kulkarni
2020-01-02 7:36 ` Singh, Balbir
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).