From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55EE7C282DD for ; Wed, 8 Jan 2020 15:04:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26D2520678 for ; Wed, 8 Jan 2020 15:04:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o0aGAl9a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26D2520678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YegjeLynRVlPNM29NCNQ5230I0a4SmNNOi97KVRR6Z0=; b=o0aGAl9aolzzR0 HnSTl3tBzSDojGM0wI1XaexCo1wYyv3xTpDU6sKvP7kJpEOY6C59d6u791j7PkfDwsTi8kHlkhKsf 16BMKbkU+kSU5rg1UF9VCt3gqWYVAYXynSYDrP8WKHBueGA9G6WLKJJo8tVaAsX4UN0oPTqUpRuYp Bvi09VsEraQCmpxCbrDXMqdy+3ujsOviEfBGz1gorlA+lfUgpURj5LO/xaF7JtpmQpGkvKeRcXMqs YEkiQym+UUc8HbJ+KmDvbTPdC5/imH3kugB+vVhf9GoStF+LINV/eILRIgDez/AFT5zNPpg1sQbpa PniSuK7BC/WPdwMH+AwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipCsq-0006rJ-Pb; Wed, 08 Jan 2020 15:04:32 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipCso-0006qv-4C for linux-nvme@lists.infradead.org; Wed, 08 Jan 2020 15:04:31 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4526468BFE; Wed, 8 Jan 2020 16:04:28 +0100 (CET) Date: Wed, 8 Jan 2020 16:04:28 +0100 From: "hch@lst.de" To: "Martin K. Petersen" Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change Message-ID: <20200108150428.GB10975@lst.de> References: <20200102075315.22652-1-sblbir@amazon.com> <20200102075315.22652-2-sblbir@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200108_070430_320608_959A2BBE X-CRM114-Status: UNSURE ( 8.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "axboe@kernel.dk" , "Chaitanya.Kulkarni@wdc.com" , "mst@redhat.com" , "jejb@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "Sangaraju, Someswarudu" , "Singh, Balbir" , "hch@lst.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Jan 07, 2020 at 10:15:34PM -0500, Martin K. Petersen wrote: > > Balbir, > > > I did this to avoid having to enforce that set_capacity() implied a > > notification. Largely to control the impact of the change by default. > > What I thought. I'm OK with set_capacity_and_notify(), btw. To some extent it might make sense to always notify from set_capacity and have a set_capacity_nonotify if we don't want to notify, as in general we probably should notify unless we have a good reason not to. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme