linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "hch@lst.de" <hch@lst.de>
To: "Singh, Balbir" <sblbir@amazon.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"Chaitanya.Kulkarni@wdc.com" <Chaitanya.Kulkarni@wdc.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"Sangaraju, Someswarudu" <ssomesh@amazon.com>,
	"hch@lst.de" <hch@lst.de>
Subject: Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use disk_set_capacity
Date: Wed, 8 Jan 2020 16:04:47 +0100	[thread overview]
Message-ID: <20200108150447.GC10975@lst.de> (raw)
In-Reply-To: <1b88bedc6d5435fa7154f3356fa3f1a3e6888ded.camel@amazon.com>

On Mon, Jan 06, 2020 at 12:46:26AM +0000, Singh, Balbir wrote:
> On Sat, 2020-01-04 at 22:27 +0000, Chaitanya Kulkarni wrote:
> > Quick question here if user executes nvme ns-rescan /dev/nvme1
> > will following code result in triggering uevent(s) for
> > the namespace(s( for which there is no change in the size ?
> > 
> > If so is that an expected behavior ?
> > 
> 
> My old code had a check to see if old_capacity != new_capacity as well.
> I can redo those bits if needed.
> 
> The expected behaviour is not clear, but the functionality is not broken, user
> space should be able to deal with a resize event where the previous capacity
> == new capacity IMHO.

I think it makes sense to not bother with a notification unless there
is an actual change.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-01-08 15:04 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  7:53 [resend v1 0/5] Add support for block disk resize notification Balbir Singh
2020-01-02  7:53 ` [resend v1 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2020-01-03  6:16   ` Chaitanya Kulkarni
2020-01-04  4:44     ` Singh, Balbir
2020-01-04 22:32       ` Chaitanya Kulkarni
2020-01-08 15:02     ` hch
2020-01-07  3:32   ` Martin K. Petersen
2020-01-07 22:30     ` Singh, Balbir
2020-01-08  3:15       ` Martin K. Petersen
2020-01-08 15:04         ` hch
2020-01-21 19:57           ` Singh, Balbir
2020-01-02  7:53 ` [resend v1 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2020-01-02  7:53 ` [resend v1 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-01-02  7:53 ` [resend v1 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-01-04 22:27   ` Chaitanya Kulkarni
2020-01-06  0:46     ` Singh, Balbir
2020-01-08 15:04       ` hch [this message]
2020-01-09  3:33         ` Martin K. Petersen
2020-01-09 13:12           ` Ewan D. Milne
2020-01-21 19:52         ` Singh, Balbir
2020-01-02  7:53 ` [resend v1 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-01-02 22:21   ` Chaitanya Kulkarni
2020-01-03  0:23     ` Singh, Balbir
2020-01-07  3:48   ` Martin K. Petersen
2020-01-07  3:57     ` James Bottomley
2020-01-07  4:39       ` Martin K. Petersen
2020-01-07 21:37         ` Ewan D. Milne
2020-01-08  2:59           ` Martin K. Petersen
2020-01-08 21:27             ` Ewan D. Milne
2020-01-07 22:28     ` Singh, Balbir
2020-01-08  3:15       ` Martin K. Petersen
2020-01-08  4:20         ` Singh, Balbir
2020-01-08 21:32         ` Ewan D. Milne
2020-01-08 15:06     ` Christoph Hellwig
2020-01-09  2:53       ` Martin K. Petersen
2020-01-06  5:59 ` [resend v1 0/5] Add support for block disk resize notification Bob Liu
2020-01-06  8:47   ` Singh, Balbir
2020-01-06  9:08     ` Bob Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108150447.GC10975@lst.de \
    --to=hch@lst.de \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mst@redhat.com \
    --cc=sblbir@amazon.com \
    --cc=ssomesh@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).