From: Keith Busch <kbusch@kernel.org>
To: Amol Grover <frextrite@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Christoph Hellwig <hch@lst.de>,
Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Subject: Re: [PATCH] drivers: nvme: target: core: Pass lockdep expression to RCU lists
Date: Sat, 11 Jan 2020 01:31:34 +0900 [thread overview]
Message-ID: <20200110163134.GA18579@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200110132356.27110-1-frextrite@gmail.com>
On Fri, Jan 10, 2020 at 06:53:58PM +0530, Amol Grover wrote:
> +#define subsys_lock_held() \
> + lockdep_is_held(&subsys->lock)
This macro requires "struct nvmet_subsys *subsys" was previously declared
in the function using it, which isn't obvious when looking at the users. I
don't think that's worth the conciseness.
> @@ -555,7 +558,8 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
> } else {
> struct nvmet_ns *old;
>
> - list_for_each_entry_rcu(old, &subsys->namespaces, dev_link) {
> + list_for_each_entry_rcu(old, &subsys->namespaces, dev_link,
> + subsys_lock_held()) {
> BUG_ON(ns->nsid == old->nsid);
> if (ns->nsid < old->nsid)
> break;
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-01-10 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 13:23 [PATCH] drivers: nvme: target: core: Pass lockdep expression to RCU lists Amol Grover
2020-01-10 15:47 ` Joel Fernandes
2020-01-10 16:31 ` Keith Busch [this message]
2020-01-10 17:10 ` Amol Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110163134.GA18579@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=frextrite@gmail.com \
--cc=hch@lst.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=paulmck@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).