Linux-NVME Archive on
 help / color / Atom feed
From: Keith Busch <>
To: Edmund Nadolski <>
Subject: Re: [PATCH] nvme: clear stale nvmeq->tags after tagset free
Date: Fri, 17 Jan 2020 01:06:02 +0900
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Jan 14, 2020 at 11:17:45AM -0700, Edmund Nadolski wrote:
> +static void nvme_exit_hctx(struct blk_mq_hw_ctx *hctx, unsigned int hctx_idx)
> +{
> +	struct nvme_queue *nvmeq = hctx->driver_data;
> +
> +	nvmeq->tags = NULL;
> +}

If you've multiple namespaces, disconnecting one of them will cause the
shared nvmeq to have NULL tags, which will crash the kernel on the very
next CQE read.

linux-nvme mailing list

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 18:17 Edmund Nadolski
2020-01-16 16:06 ` Keith Busch [this message]
2020-01-16 22:06   ` Nadolski, Edmund
2020-01-16 23:26     ` Keith Busch

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on

Archives are clonable:
	git clone --mirror linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ \
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone