From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B33C33CAF for ; Thu, 16 Jan 2020 17:01:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05B042077B for ; Thu, 16 Jan 2020 17:01:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SNt0VLP8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05B042077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v2UjNIiVYILqCyNIETH5VQdOuuhnoDvMoWHsXLS+skc=; b=SNt0VLP8AocBCA eQWTy9vFdnRZ1CfxOxvmLCZGpvkU6Yo9uEzl33SJEnzKEO7BMmsURSz/unnx9FMjk/F4+H+cR/vvd IP7t/bAtXpMOuIsAWq4yxLtmZg7/BLnJ1MgUPjgUpJeW71bTB97/0QNI6hOrkypaY2D8WajkBeB54 /AeDwoYw2iR27wJ8z5z8nh3tPR2s/Ob69jjw55RD/FQe7/DYEERJAYr/PFPiYpwfpGYA3TrSXUTM2 vIEVQOFwEq5i1mtqOUlec6PYpE782jpD7GxjpZq76dGKpThYLtFkbitFfdRkjLdURQCaqvbYN4ZRs 3yk39B8eTopBR4b98Rfg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1is8W2-0001Fs-2h; Thu, 16 Jan 2020 17:01:06 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1is8QV-00035N-93 for linux-nvme@lists.infradead.org; Thu, 16 Jan 2020 16:55:29 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2FF2468B05; Thu, 16 Jan 2020 17:55:20 +0100 (CET) Date: Thu, 16 Jan 2020 17:55:19 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH V2 4/4] nvmet: update AEN list and array at one place Message-ID: <20200116165519.GA23960@lst.de> References: <20200109050244.5493-1-chaitanya.kulkarni@wdc.com> <20200109050244.5493-5-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200109050244.5493-5-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200116_085523_491263_E2587166 X-CRM114-Status: UNSURE ( 7.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > + > + if (!status) > + return; > + > + mutex_lock(&ctrl->lock); > + while (ctrl->nr_async_event_cmds) { > + req = ctrl->async_event_cmds[--ctrl->nr_async_event_cmds]; > + mutex_unlock(&ctrl->lock); > + nvmet_req_complete(req, status); > + mutex_lock(&ctrl->lock); > + } > + mutex_unlock(&ctrl->lock); I think this hunk doesn't belong into nvmet_async_events_process. I'd keep it as nvmet_async_events_free(), and then call nvmet_async_events_process(ctrl, NVME_SC_INTERNAL | NVME_SC_DNR); nvmet_async_events_free(ctrl); in nvmet_sq_destroy (which would really benefit from a local ctrl variable now). Otherwise this looks good. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme