From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3A5C2D0DB for ; Thu, 30 Jan 2020 15:04:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DE612051A for ; Thu, 30 Jan 2020 15:04:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KhkvoQ10" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DE612051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RmlsQlt3VszO2FVTjZTtJP8XOboIWvJ0aY5Hapcaa0=; b=KhkvoQ10oPde6V LcNA2lpAJjujFaAWJLKnpNqd8pIQuoo1mdXV4qjSyGHUUSclrJ8V0oz2uob3rDTmgTxyYz7nrGmeV IUyrSZMFGysPjDCWgnDCjWR4jr1Q4OpKoWn/0x/KihhYZ0RlTAx8BAoNhZYP+UZiSGAoC2xa/Nj/l 04OBEvyA+LfruCi7QXVPhrTgQyi7YsxFb2Irv5CpQ2pi1OJ2mdFPCaACStYdiHSXmFeF1ZreG3Yh3 L/pu5n+vkaFNXCtzMyhXTU1ZwQ39tU0THsWEIWKcSJJ/N0HnAw3yStucaKo6lREZfrdev1YPqQdgr PgwU/GHJV7ugMqSqwkyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixBNF-0006zM-Tc; Thu, 30 Jan 2020 15:04:53 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixBND-0006yN-V3; Thu, 30 Jan 2020 15:04:51 +0000 Date: Thu, 30 Jan 2020 07:04:51 -0800 From: Christoph Hellwig To: Arnd Bergmann Subject: Re: [PATCH] nvme: fix uninitialized-variable warning Message-ID: <20200130150451.GA25427@infradead.org> References: <20200107214215.935781-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200107214215.935781-1-arnd@arndb.de> X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oleksandr Natalenko , Bart Van Assche , Chaitanya Kulkarni , Marta Rybczynska , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe , Hannes Reinecke , Keith Busch , Christoph Hellwig , Sagi Grimberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Jan 07, 2020 at 10:42:08PM +0100, Arnd Bergmann wrote: > Fixes: mmtom ("init/Kconfig: enable -O3 for all arches") > Signed-off-by: Arnd Bergmann > --- > drivers/nvme/host/core.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 667f18f465be..6f0991e8c5cc 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -825,14 +825,15 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd, > int ret; > > req = nvme_alloc_request(q, cmd, flags, qid); > - if (IS_ERR(req)) > - return PTR_ERR(req); > + ret = PTR_ERR_OR_ZERO(req); > + if (ret < 0) > + return ret; This one is just gross. I think we'll need to find some other fix that doesn't obsfucate the code as much. > > req->timeout = timeout ? timeout : ADMIN_TIMEOUT; > > if (buffer && bufflen) { > ret = blk_rq_map_kern(q, req, buffer, bufflen, GFP_KERNEL); > - if (ret) > + if (ret < 0) OTOH if this shuts up a compiler warning I'd be perfectly fine with it. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme