From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8ABC2D0DB for ; Thu, 30 Jan 2020 15:48:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 013B820674 for ; Thu, 30 Jan 2020 15:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jfhOG0x2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 013B820674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OFw93yCkZnfOwOWuVxHQi6AfzUVp3j1jCZXt5YrCkzE=; b=jfhOG0x2d8Sy4O s4vUfyajrl927GoC2kwZHOXTX2uty2YHA8aYDg387tZPrjFU4qCyL7SmSc7U2RUtynrvehO9SyxM2 Hc9kJTqltyNy3mng4+E2E8St9Sx/3j1FB6I+cGSc6FyW0IKW1UDqMElnjarafORCF2iOVuzTI3+GI X8L0fzPqDIxMtjmFM9czMeUmVoA1KaMeAlcnn0jsWh3PkvOGBvFfUOArIYBqJLu3eWF7cGJ5WDIje 1Lelbauj2z9tYfT2Jf0jJtYsBui+nwMBDDE477pQAZSsgvQiNSdYsW0G3JqZiBzYMXs90rF7lFRJU Pjbu+lqZuDKg7lb0uoSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixC3G-0000hU-TZ; Thu, 30 Jan 2020 15:48:18 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixC3D-0000h0-JI; Thu, 30 Jan 2020 15:48:15 +0000 Date: Thu, 30 Jan 2020 07:48:15 -0800 From: Christoph Hellwig To: Arnd Bergmann Subject: Re: [PATCH] nvme: fix uninitialized-variable warning Message-ID: <20200130154815.GA2463@infradead.org> References: <20200107214215.935781-1-arnd@arndb.de> <20200130150451.GA25427@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oleksandr Natalenko , Jens Axboe , Sagi Grimberg , Chaitanya Kulkarni , Marta Rybczynska , "linux-kernel@vger.kernel.org" , linux-nvme@lists.infradead.org, Christoph Hellwig , Hannes Reinecke , Keith Busch , Christoph Hellwig , Bart Van Assche Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jan 30, 2020 at 04:36:48PM +0100, Arnd Bergmann wrote: > > This one is just gross. I think we'll need to find some other fix > > that doesn't obsfucate the code as much. > > Initializing the nvme_result in nvme_features() would do it, as would > setting it in the error path in __nvme_submit_sync_cmd() -- either > way the compiler cannot be confused about whether it is initialized > later on. Given that this is outside the hot path we can just zero the whole structure before submitting the I/O. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme