From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Edmund Nadolski <edmund.nadolski@intel.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 1/1] nvme: clear io tags when freeing tagset
Date: Fri, 31 Jan 2020 02:47:32 +0900 [thread overview]
Message-ID: <20200130174732.GA7915@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200130145335.GA8412@infradead.org>
On Thu, Jan 30, 2020 at 06:53:35AM -0800, Christoph Hellwig wrote:
> +static inline struct blk_mq_tags *nvme_queue_tagset(struct nvme_queue *nvmeq)
> +{
> + if (!nvmeq->qid)
> + return nvmeq->dev->admin_tagset.tags[0];
> + return nvmeq->dev->tagset.tags[nvmeq->qid - 1];
> +}
It's been this way for so long, I thought we cached the address of the
tags in the nvmeq using it to avoid this more complex lookip, so I told
Ed not do the above. But the original commit doing this was to remove
relying on a specific hctx to reach the tags, so it's nothing to do with
any observed performance change ... And this makes struct nvme_queue
smaller too, so all the better.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-01-30 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 20:19 [PATCH v2 0/1] nvme: clear stale nvmeq->tags after tagset free Edmund Nadolski
2020-01-23 20:19 ` [PATCH v2 1/1] nvme: clear io tags when freeing tagset Edmund Nadolski
2020-01-24 18:29 ` Keith Busch
2020-01-30 14:53 ` Christoph Hellwig
2020-01-30 17:47 ` Keith Busch [this message]
2020-01-30 18:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130174732.GA7915@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=edmund.nadolski@intel.com \
--cc=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).