From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers
Date: Sat, 8 Feb 2020 09:44:57 +0900 [thread overview]
Message-ID: <20200208004457.GA15482@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200208002111.10220-1-sagi@grimberg.me>
On Fri, Feb 07, 2020 at 04:21:10PM -0800, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
The code looks fine, but could you say more in the change log why this
is needed now?
> +static ssize_t nvme_sysfs_show_hostnqn(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
> +
> + return snprintf(buf, PAGE_SIZE, "%s\n", ctrl->opts->host->nqn);
> +}
> +static DEVICE_ATTR(hostnqn, S_IRUGO, nvme_sysfs_show_hostnqn, NULL);
> +
> static ssize_t nvme_sysfs_show_address(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> @@ -3267,6 +3277,7 @@ static struct attribute *nvme_dev_attrs[] = {
> &dev_attr_numa_node.attr,
> &dev_attr_queue_count.attr,
> &dev_attr_sqsize.attr,
> + &dev_attr_hostnqn.attr,
> NULL
> };
>
> @@ -3280,6 +3291,8 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
> return 0;
> if (a == &dev_attr_address.attr && !ctrl->ops->get_address)
> return 0;
> + if (a == &dev_attr_hostnqn.attr && (!ctrl->opts))
> + return 0;
>
> return a->mode;
> }
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-08 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 0:21 [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers Sagi Grimberg
2020-02-08 0:21 ` [PATCH 2/2] nvme: expose hostid " Sagi Grimberg
2020-02-08 0:44 ` Keith Busch [this message]
2020-02-08 1:05 ` [PATCH 1/2] nvme: expose hostnqn " Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200208004457.GA15482@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).