Linux-NVME Archive on
 help / color / Atom feed
From: Keith Busch <>
To: James Smart <>
Cc: Nigel Kirkland <>,
Subject: Re: [PATCH v2] nvme: prevent warning triggered by nvme_stop_keep_alive
Date: Wed, 12 Feb 2020 05:26:09 +0900
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Feb 10, 2020 at 04:01:45PM -0800, James Smart wrote:
> Delayed keep alive work is queued on system workqueue and may be cancelled
> via nvme_stop_keep_alive from nvme_reset_wq, nvme_fc_wq or nvme_wq.
> Check_flush_dependency detects mismatched attributes between the work-queue
> context used to cancel the keep alive work and system-wq. Specifically
> system-wq does not have the WQ_MEM_RECLAIM flag, whereas the contexts used
> to cancel keep alive work have WQ_MEM_RECLAIM flag.
> Example warning:
>   workqueue: WQ_MEM_RECLAIM nvme-reset-wq:nvme_fc_reset_ctrl_work [nvme_fc]
> 	is flushing !WQ_MEM_RECLAIM events:nvme_keep_alive_work [nvme_core]
> To avoid the flags mismatch, delayed keep alive work is queued on nvme_wq.
> However this creates a secondary concern where work and a request to cancel
> that work may be in the same work queue - namely err_work in the rdma and
> tcp transports, which will want to flush/cancel the keep alive work which
> will now be on nvme_wq.
> After reviewing the transports, it looks like err_work can be moved to
> nvme_reset_wq. In fact that aligns them better with transition into
> RESETTING and performing related reset work in nvme_reset_wq.
> Change nvme-rdma and nvme-tcp to perform err_work in nvme_reset_wq.
> Signed-off-by: Nigel Kirkland <>
> Signed-off-by: James Smart <>
> Reviewed-by: Sagi Grimberg <>
> Reviewed-by: Christoph Hellwig <>

Thanks James, applied to nvme-5.6-rc.

linux-nvme mailing list

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  0:01 James Smart
2020-02-11 20:26 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on

Archives are clonable:
	git clone --mirror linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ \
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone