Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info
@ 2020-02-14 10:48 Yi Zhang
  2020-02-14 13:53 ` David Milburn
  2020-02-14 14:26 ` Keith Busch
  0 siblings, 2 replies; 3+ messages in thread
From: Yi Zhang @ 2020-02-14 10:48 UTC (permalink / raw)
  To: kbusch, hch; +Cc: dmilburn, sujith_pandel, emilne, linux-nvme

nvme fw-activate operation will get bellow warning log,
fix it by update the parameter order

[  113.231513] nvme nvme0: Get FW SLOT INFO log error

Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages")
Reported-by: Sujith Pandel <sujith_pandel@dell.com>
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 5dc32b72e7fa..641c07347e8d 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3867,7 +3867,7 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl)
 	if (!log)
 		return;
 
-	if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log,
+	if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log,
 			sizeof(*log), 0))
 		dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
 	kfree(log);
-- 
2.21.0


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info
  2020-02-14 10:48 [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info Yi Zhang
@ 2020-02-14 13:53 ` David Milburn
  2020-02-14 14:26 ` Keith Busch
  1 sibling, 0 replies; 3+ messages in thread
From: David Milburn @ 2020-02-14 13:53 UTC (permalink / raw)
  To: Yi Zhang, kbusch, hch; +Cc: sujith_pandel, emilne, linux-nvme

Hi,

On 02/14/2020 04:48 AM, Yi Zhang wrote:
> nvme fw-activate operation will get bellow warning log,
> fix it by update the parameter order
> 
> [  113.231513] nvme nvme0: Get FW SLOT INFO log error
> 
> Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages")
> Reported-by: Sujith Pandel <sujith_pandel@dell.com>
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> ---
>   drivers/nvme/host/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 5dc32b72e7fa..641c07347e8d 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3867,7 +3867,7 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl)
>   	if (!log)
>   		return;
>   
> -	if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log,
> +	if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log,
>   			sizeof(*log), 0))
>   		dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
>   	kfree(log);
> 

The controller returns a status of "Invalid Log Page" from
nvme_get_log() on different devices.

Reviewed-by: David Milburn <dmilburn@redhat.com>

Thanks,
David


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info
  2020-02-14 10:48 [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info Yi Zhang
  2020-02-14 13:53 ` David Milburn
@ 2020-02-14 14:26 ` Keith Busch
  1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2020-02-14 14:26 UTC (permalink / raw)
  To: Yi Zhang; +Cc: dmilburn, sujith_pandel, hch, linux-nvme, emilne

On Fri, Feb 14, 2020 at 06:48:02PM +0800, Yi Zhang wrote:
> nvme fw-activate operation will get bellow warning log,
> fix it by update the parameter order
> 
> [  113.231513] nvme nvme0: Get FW SLOT INFO log error
> 
> Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages")
> Reported-by: Sujith Pandel <sujith_pandel@dell.com>
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>

Oops, thanks for the fix. Applied to nvme-5.6-rc.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 10:48 [PATCH] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info Yi Zhang
2020-02-14 13:53 ` David Milburn
2020-02-14 14:26 ` Keith Busch

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git