From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FB4C34047 for ; Wed, 19 Feb 2020 15:21:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74BA824654 for ; Wed, 19 Feb 2020 15:21:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Au3GPpih" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74BA824654 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kYm7FkgdFKXqWHR1miRugO6nCeQhi7G7ksg49VFDEqo=; b=Au3GPpih7NRa6q xV/y/JToQkTqK82weT9su+TEtAdzuCp7mu9GcmQf7LTUyWCqEO4QK5BgRMyM3nq4vn4U2mRVyNmmK epC25itYGOgTpPrmO7zREDJeealxR0EStGzIhj2j9D04rxac5LoqVuKPdhWlGifsz75zfQs+037GI lnSVJFHfIwaSD9/py/4/o/N+0e2Xar3d4rtZZ90pZKlOuDuqerdDdci9gm3/6A3/yQ3Md7nvhvWsp 7KaL3A//a0u3Ox/gHk1cIJbfiE63SmIq2vctV39O024QZ0H38J/lpqnYsdjbh8uyIs4po6whqbIJt Gyz4auvChQxZOwC6qpAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4RAI-00058z-9U; Wed, 19 Feb 2020 15:21:30 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4RAB-000589-EL for linux-nvme@lists.infradead.org; Wed, 19 Feb 2020 15:21:26 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4536968B20; Wed, 19 Feb 2020 16:21:20 +0100 (CET) Date: Wed, 19 Feb 2020 16:21:20 +0100 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCH] nvme: fix uninitialized-variable warning Message-ID: <20200219152120.GA18253@lst.de> References: <20200107214215.935781-1-arnd@arndb.de> <20200130150451.GA25427@infradead.org> <20200130154815.GA2463@infradead.org> <20200213195106.GA8256@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200213195106.GA8256@redsun51.ssa.fujisawa.hgst.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_072123_631448_599DB074 X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oleksandr Natalenko , Jens Axboe , Sagi Grimberg , Arnd Bergmann , Chaitanya Kulkarni , "linux-kernel@vger.kernel.org" , linux-nvme@lists.infradead.org, Christoph Hellwig , Marta Rybczynska , Hannes Reinecke , Christoph Hellwig , Bart Van Assche Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Feb 14, 2020 at 04:51:06AM +0900, Keith Busch wrote: > On Thu, Jan 30, 2020 at 07:48:15AM -0800, Christoph Hellwig wrote: > > On Thu, Jan 30, 2020 at 04:36:48PM +0100, Arnd Bergmann wrote: > > > > This one is just gross. I think we'll need to find some other fix > > > > that doesn't obsfucate the code as much. > > > > > > Initializing the nvme_result in nvme_features() would do it, as would > > > setting it in the error path in __nvme_submit_sync_cmd() -- either > > > way the compiler cannot be confused about whether it is initialized > > > later on. > > > > Given that this is outside the hot path we can just zero the whole > > structure before submitting the I/O. > > I think this should be okay: This looks good. Can you send a formal patch? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme