From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
sagi@grimberg.me, linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCH] nvme: Fix uninitialized-variable warning
Date: Wed, 19 Feb 2020 17:22:20 +0100 [thread overview]
Message-ID: <20200219162220.GA19584@lst.de> (raw)
In-Reply-To: <20200219161950.14460-1-kbusch@kernel.org>
On Thu, Feb 20, 2020 at 01:19:50AM +0900, Keith Busch wrote:
> gcc may detect a false positive on nvme using an unintialized variable
> if setting features fails. Since this is not a fast path, explicitly
> initialize this variable to suppress the warning.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-19 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 16:19 [PATCH] nvme: Fix uninitialized-variable warning Keith Busch
2020-02-19 16:22 ` Christoph Hellwig [this message]
2020-02-20 7:43 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2020-01-07 21:42 [PATCH] nvme: fix " Arnd Bergmann
2020-01-30 15:04 ` Christoph Hellwig
2020-01-30 15:36 ` Arnd Bergmann
2020-01-30 15:48 ` Christoph Hellwig
2020-02-13 19:51 ` Keith Busch
2020-02-19 15:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219162220.GA19584@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).