From: Christoph Hellwig <hch@lst.de>
To: Rupesh Girase <rgirase@redhat.com>
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: log additional message for controller status
Date: Mon, 24 Feb 2020 18:06:32 +0100 [thread overview]
Message-ID: <20200224170632.GA7064@lst.de> (raw)
In-Reply-To: <1582561924-8017-1-git-send-email-rgirase@redhat.com>
On Mon, Feb 24, 2020 at 10:02:04PM +0530, Rupesh Girase wrote:
> Logging the controller fatal and ready status would help to
> identfy if issue lies within kernel nvme subsytem or
> controller is unhealthy.
>
> Signed-off-by: Rupesh Girase <rgirase@redhat.com>
There should be no tabs before the commit message.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-24 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 16:32 [PATCH] nvme: log additional message for controller status Rupesh Girase
2020-02-24 17:06 ` Christoph Hellwig [this message]
2020-02-24 18:54 ` Chaitanya Kulkarni
2020-02-25 15:55 ` Keith Busch
2020-02-25 20:24 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224170632.GA7064@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rgirase@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).