From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B243C11D2F for ; Mon, 24 Feb 2020 17:06:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EDC921744 for ; Mon, 24 Feb 2020 17:06:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ab1fVMqV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EDC921744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DZXsqzc0itQ4ohv+j5LRnSRgp6JENdvDobIcUJhzpLM=; b=Ab1fVMqViGNciu X2Zm/gTjlsSVjzSJsjUofeoheB77+p3vGkiOa9n/m2ldtNJUq6P1wan+Om1uKPAQobyMw056H2MeO 0vRc09zGPC73JZzkQvFfUa7I1lm7rbgu7ybaFmKKH1ehtOCTICvhtsXWnyyxdJlbx4uUhz5SxAx6m pH0j+ODOC7WbbHjWSlm0CtYt9f3TUo4Z3xNvwYnsMdjIE2NM8TJkiDUef2jc9SlMHD2FAao/MI/Xo zVZiRTwCTcuT4+D2gWpkEB5XhCzP9JlA/1hbmdz1iFGSfOB3LOopVZF4zToMbqu8sAbHLtsa/Kgv+ dh2qiWBcbj4M5twcPMYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6HBp-0000JS-Uz; Mon, 24 Feb 2020 17:06:41 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6HBm-0000B7-Lw for linux-nvme@lists.infradead.org; Mon, 24 Feb 2020 17:06:40 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AF90A68B20; Mon, 24 Feb 2020 18:06:32 +0100 (CET) Date: Mon, 24 Feb 2020 18:06:32 +0100 From: Christoph Hellwig To: Rupesh Girase Subject: Re: [PATCH] nvme: log additional message for controller status Message-ID: <20200224170632.GA7064@lst.de> References: <1582561924-8017-1-git-send-email-rgirase@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1582561924-8017-1-git-send-email-rgirase@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_090638_890281_4FC86D64 X-CRM114-Status: UNSURE ( 7.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Feb 24, 2020 at 10:02:04PM +0530, Rupesh Girase wrote: > Logging the controller fatal and ready status would help to > identfy if issue lies within kernel nvme subsytem or > controller is unhealthy. > > Signed-off-by: Rupesh Girase There should be no tabs before the commit message. Otherwise this looks good: Reviewed-by: Christoph Hellwig _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme