From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DBEFC11D32 for ; Mon, 24 Feb 2020 17:13:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2448920836 for ; Mon, 24 Feb 2020 17:13:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n8UZR6/X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2448920836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OnxMdKhatLl5R1aQ7OuyR89oKe3L/s+efC4dbNtogQ0=; b=n8UZR6/X3pQB1R YSlVCJvd2G3+w+c2WiKvSHFSCtr+T1mX89z3cjn6x23I59uTq8ZNAltR0R/ArF53yrs721L44Vt6N 6+IaDrX27ASC7edvDNiCJsWeuj1EVqyuopte0dMQNmcjQUaQ0wJvzVoTNb/vMhnbUzhqMnCIsJH4j IVI/0AMuyIp9HQtpAtwbaan3Oed8SmqYc6whRSN34Pc+uHYXf8SoTHIJoNuvqFMh5dvxg2hTFuo1S qVG8LU59WFaH4Z23nT3ywG15VZsy0LFVjy8Rj5AxVaul3tj3gUiwJEzzE7EGk2EJN/gw4kwJEc1op fLwLjyxb+dbJbClXmi3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6HI6-0002Ni-9E; Mon, 24 Feb 2020 17:13:10 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6HI3-0002ND-Qd for linux-nvme@lists.infradead.org; Mon, 24 Feb 2020 17:13:09 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BF3C668B20; Mon, 24 Feb 2020 18:13:04 +0100 (CET) Date: Mon, 24 Feb 2020 18:13:04 +0100 From: Christoph Hellwig To: Andy Shevchenko Subject: Re: [PATCH v1] nvme-pci: Move enumeration by class to be last in the table Message-ID: <20200224171304.GA7171@lst.de> References: <20200224093823.17534-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200224093823.17534-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_091308_065463_2AD0A860 X-CRM114-Status: UNSURE ( 8.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Benjamin Herrenschmidt , linux-nvme@lists.infradead.org, Jens Axboe , Keith Busch , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Feb 24, 2020 at 11:38:23AM +0200, Andy Shevchenko wrote: > It's unusual that we have enumeration by class in the middle of the table. > It might potentially be problematic in the future if we add another entry > after it. > > So, move class matching entry to be the last in the ID table. > > While here, group Apple devices together with an additional comment line. Looks good: Reviewed-by: Christoph Hellwig _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme