From: Keith Busch <kbusch@kernel.org>
To: Israel Rukshin <israelr@mellanox.com>
Cc: Max Gurtovoy <maxg@mellanox.com>,
Shlomi Nimrodi <shlomin@mellanox.com>,
Sagi Grimberg <sagi@grimberg.me>,
Linux-nvme <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/6] nvme-pci: Make nvme_pci_free_ctrl symmetric to nvme_probe
Date: Tue, 24 Mar 2020 01:21:11 +0900 [thread overview]
Message-ID: <20200323162111.GA24680@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <1584899989-14623-3-git-send-email-israelr@mellanox.com>
On Sun, Mar 22, 2020 at 07:59:45PM +0200, Israel Rukshin wrote:
> + nvme_release_prp_pools(dev);
> + nvme_dev_unmap(dev);
> + put_device(dev->dev);
> + kfree(dev->queues);
> kfree(dev);
> }
>
> @@ -2875,8 +2877,6 @@ static void nvme_remove(struct pci_dev *pdev)
> nvme_dev_remove_admin(dev);
> nvme_free_queues(dev, 0);
> nvme_uninit_ctrl(&dev->ctrl);
> - nvme_release_prp_pools(dev);
> - nvme_dev_unmap(dev);
> nvme_put_ctrl(&dev->ctrl);
> }
I think we actually need the nvme_dev_unmap() call to remain inline with
nvme_remove(). If you hot remove the drive while an application has an
active reference on it, we still need to release the PCI resources so
that they're available for the next device inserted.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-23 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 17:59 [PATCH 0/6 V2] nvme: Fixes for deleting a ctrl before it was created Israel Rukshin
2020-03-22 17:59 ` [PATCH 1/6] nvme: Remove unused return code from nvme_delete_ctrl_sync Israel Rukshin
2020-03-22 17:59 ` [PATCH 2/6] nvme-pci: Make nvme_pci_free_ctrl symmetric to nvme_probe Israel Rukshin
2020-03-23 7:27 ` Christoph Hellwig
2020-03-23 16:21 ` Keith Busch [this message]
2020-03-22 17:59 ` [PATCH 3/6] nvme: Fix ctrl use-after-free during sysfs deletion Israel Rukshin
2020-03-23 7:32 ` Christoph Hellwig
2020-03-23 16:10 ` Israel Rukshin
2020-03-23 17:23 ` Christoph Hellwig
2020-03-22 17:59 ` [PATCH 4/6] nvme: Fix controller creation races with teardown flow Israel Rukshin
2020-03-23 7:34 ` Christoph Hellwig
2020-03-22 17:59 ` [PATCH 5/6] nvme-rdma: Add warning on state change failure at nvme_rdma_setup_ctrl Israel Rukshin
2020-03-23 7:34 ` Christoph Hellwig
2020-03-22 17:59 ` [PATCH 6/6] nvme-tcp: Add warning on state change failure at nvme_tcp_setup_ctrl Israel Rukshin
2020-03-23 7:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323162111.GA24680@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).