From: Max Gurtovoy <maxg@mellanox.com>
To: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me, martin.petersen@oracle.com,
jsmart2021@gmail.com, linux-rdma@vger.kernel.org
Cc: axboe@kernel.dk, vladimirk@mellanox.com, shlomin@mellanox.com,
israelr@mellanox.com, idanb@mellanox.com, jgg@mellanox.com,
oren@mellanox.com, maxg@mellanox.com
Subject: [PATCH 00/17 V5] nvme-rdma/nvmet-rdma: Add metadata/T10-PI support
Date: Fri, 27 Mar 2020 20:15:27 +0300 [thread overview]
Message-ID: <20200327171545.98970-1-maxg@mellanox.com> (raw)
Hello Sagi, Christoph, Keith, Martin, James and Co
This patchset adds metadata (T10-PI) support for NVMeoF/RDMA host side
and target side, using signature verbs API. This set starts with a few
preparation commits to the NVMe host core layer. It continues with
NVMeoF/RDMA host implementation + few preparation commits to the RDMA/rw
API and to NVMe target core layer. The patchset ends with NVMeoF/RDMA
target implementation. Also patch for NVMe-cli added to this series.
In V5 I mainly did some renamings and removed 2 patches to get_mdts that
were already merged to main branch. I tried get some inspiration from
James suggestion of the settings in NVMe core, but unfortunately couldn't
take much from there and I stayed with Christoph suggestion for features
flag per namespace. I found the code more readable in this form and
hopefully we can continue with the review and the merge soon.
Configuration:
Host:
- nvme connect --pi_enable --transport=rdma --traddr=10.0.1.1 --nqn=test-nvme
Target:
- echo 1 > /config/nvmet/subsystems/${NAME}/attr_pi_enable
- echo 1 > /config/nvmet/ports/${PORT_NUM}/param_pi_enable
The code was tested using Mellanox's ConnectX-4/ConnectX-5 HCAs.
This series applies on top of nvme_5.7 branch cleanly.
Changes from v4:
- removed get_mdts patches (merged)
- added enum nvme_ns_features instead of defines (patch 1/17)
- rename pi/prot to md (patches 2/17 + 6/17 + 8/17 + 9/17 + 10/17)
- another rebase
Changes from v3:
- Added Reviewed-by signatures
- New RDMA/rw patch (Patch 17/19)
- Add mdts setting op for controllers (Patches 14/19, 18/19)
- Rename NVME_NS_DIX_SUPPORTED to NVME_NS_MD_HOST_SUPPORTED and
NVME_NS_DIF_SUPPORTED to NVME_NS_MD_CTRL_SUPPORTED (Patch 01/19)
- Split "nvme: Introduce namespace features flag" patch (patch 02/19)
- Rename nvmet_rdma_set_diff_domain to nvmet_rdma_set_sig_domain
and nvme_rdma_set_diff_domain to nvme_rdma_set_sig_domain
(Patches 08/19, 19/19)
- Remove ns parameter from nvme_rdma_set_sig_domain/nvmet_rdma_set_sig_domain
functions (patch 08/19, 19/19)
- Rebase over nvme-5.7 branch
Changes from v2:
- Convert the virtual start sector (which passed to bip_set_seed function)
to be in integrity interval units (Patch 14/15)
- Clarify some commit messages
Changes from v1:
- Added Reviewed-by signatures
- Added namespace features flag (Patch 01/15)
- Remove nvme_ns_has_pi function (Patch 01/15)
- Added has_pi field to struct nvme_request (Patch 01/15)
- Subject change for patch 02/15
- Fix comment for PCI metadata (Patch 03/15)
- Rebase over "nvme: Avoid preallocating big SGL for data" patchset
- Introduce NVME_INLINE_PROT_SG_CNT flag (Patch 05/15)
- Introduce nvme_rdma_sgl structure (Patch 06/15)
- Remove first_sgl pointer from struct nvme_rdma_request (Patch 06/15)
- Split nvme-rdma patches (Patches 06/15, 07/15)
- Rename is_protected to use_pi (Patch 07/15)
- Refactor nvme_rdma_get_max_fr_pages function (Patch 07/15)
- Added ifdef CONFIG_BLK_DEV_INTEGRITY (Patches 07/15, 09/15, 13/15,
14/15, 15/15)
- Added port configfs pi_enable (Patch 14/15)
Israel Rukshin (12):
nvme: introduce namespace features flag
nvme: Add has_md field to the nvme_req structure
nvme-fabrics: Allow user enabling metadata/T10-PI support
nvme: introduce NVME_INLINE_MD_SG_CNT
nvme-rdma: Introduce nvme_rdma_sgl structure
nvmet: prepare metadata request
nvmet: add metadata characteristics for a namespace
nvmet: Rename nvmet_rw_len to nvmet_rw_data_len
nvmet: Rename nvmet_check_data_len to nvmet_check_transfer_len
nvme: Add Metadata Capabilities enumerations
nvmet: Add metadata/T10-PI support
nvmet: Add metadata support for block devices
Max Gurtovoy (5):
nvme: Enforce extended LBA format for fabrics metadata
nvme: introduce max_integrity_segments ctrl attribute
nvme-rdma: add metadata/T10-PI support
RDMA/rw: Expose maximal page list for a device per 1 MR
nvmet-rdma: Add metadata/T10-PI support
drivers/infiniband/core/rw.c | 14 +-
drivers/nvme/host/core.c | 79 +++++---
drivers/nvme/host/fabrics.c | 11 ++
drivers/nvme/host/fabrics.h | 3 +
drivers/nvme/host/nvme.h | 12 +-
drivers/nvme/host/pci.c | 7 +
drivers/nvme/host/rdma.c | 367 +++++++++++++++++++++++++++++++++-----
drivers/nvme/target/admin-cmd.c | 33 +++-
drivers/nvme/target/configfs.c | 61 +++++++
drivers/nvme/target/core.c | 54 ++++--
drivers/nvme/target/discovery.c | 8 +-
drivers/nvme/target/fabrics-cmd.c | 19 +-
drivers/nvme/target/io-cmd-bdev.c | 113 +++++++++++-
drivers/nvme/target/io-cmd-file.c | 6 +-
drivers/nvme/target/nvmet.h | 38 +++-
drivers/nvme/target/rdma.c | 245 +++++++++++++++++++++++--
include/linux/nvme.h | 2 +
include/rdma/rw.h | 1 +
18 files changed, 946 insertions(+), 127 deletions(-)
--
1.8.3.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2020-03-27 17:16 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 17:15 Max Gurtovoy [this message]
2020-03-27 17:15 ` [PATCH 1/1] nvme-cli/fabrics: Add pi_enable param to connect cmd Max Gurtovoy
2020-03-27 17:15 ` [PATCH 01/17] nvme: introduce namespace features flag Max Gurtovoy
2020-04-21 11:59 ` Christoph Hellwig
2020-04-21 15:53 ` James Smart
2020-04-21 18:11 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 02/17] nvme: Add has_md field to the nvme_req structure Max Gurtovoy
2020-04-21 11:59 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 03/17] nvme: Enforce extended LBA format for fabrics metadata Max Gurtovoy
2020-04-21 12:08 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 04/17] nvme: introduce max_integrity_segments ctrl attribute Max Gurtovoy
2020-04-21 12:09 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 05/17] nvme-fabrics: Allow user enabling metadata/T10-PI support Max Gurtovoy
2020-04-21 12:12 ` Christoph Hellwig
2020-04-21 15:17 ` Christoph Hellwig
2020-04-22 22:07 ` Max Gurtovoy
2020-04-22 22:24 ` James Smart
2020-04-22 22:39 ` Max Gurtovoy
2020-04-23 5:54 ` Christoph Hellwig
2020-04-23 7:30 ` Max Gurtovoy
2020-04-24 7:06 ` Christoph Hellwig
2020-04-26 9:48 ` Max Gurtovoy
2020-04-27 6:04 ` Christoph Hellwig
2020-04-27 13:52 ` Max Gurtovoy
2020-04-27 13:54 ` Christoph Hellwig
2020-04-28 9:18 ` Max Gurtovoy
2020-04-23 5:53 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 06/17] nvme: introduce NVME_INLINE_MD_SG_CNT Max Gurtovoy
2020-04-21 12:12 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 07/17] nvme-rdma: Introduce nvme_rdma_sgl structure Max Gurtovoy
2020-04-21 12:13 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 08/17] nvme-rdma: add metadata/T10-PI support Max Gurtovoy
2020-04-21 12:20 ` Christoph Hellwig
2020-04-23 9:22 ` Max Gurtovoy
2020-04-24 7:09 ` Christoph Hellwig
2020-04-26 10:04 ` Max Gurtovoy
2020-03-27 17:15 ` [PATCH 09/17] nvmet: prepare metadata request Max Gurtovoy
2020-04-21 15:21 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 10/17] nvmet: add metadata characteristics for a namespace Max Gurtovoy
2020-04-21 15:23 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 11/17] nvmet: Rename nvmet_rw_len to nvmet_rw_data_len Max Gurtovoy
2020-03-27 17:15 ` [PATCH 12/17] nvmet: Rename nvmet_check_data_len to nvmet_check_transfer_len Max Gurtovoy
2020-03-27 17:15 ` [PATCH 13/17] nvme: Add Metadata Capabilities enumerations Max Gurtovoy
2020-04-21 15:24 ` Christoph Hellwig
2020-04-23 12:09 ` Max Gurtovoy
2020-04-24 7:12 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 14/17] nvmet: Add metadata/T10-PI support Max Gurtovoy
2020-04-21 15:30 ` Christoph Hellwig
2020-04-23 12:39 ` Max Gurtovoy
2020-04-24 7:14 ` Christoph Hellwig
2020-04-26 10:50 ` Max Gurtovoy
2020-04-27 6:06 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 15/17] nvmet: Add metadata support for block devices Max Gurtovoy
2020-04-21 15:33 ` Christoph Hellwig
2020-04-23 17:25 ` Max Gurtovoy
2020-04-24 7:54 ` Christoph Hellwig
2020-03-27 17:15 ` [PATCH 16/17] RDMA/rw: Expose maximal page list for a device per 1 MR Max Gurtovoy
2020-03-27 17:15 ` [PATCH 17/17] nvmet-rdma: Add metadata/T10-PI support Max Gurtovoy
2020-04-21 15:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327171545.98970-1-maxg@mellanox.com \
--to=maxg@mellanox.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=idanb@mellanox.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=jsmart2021@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=oren@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).