From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] nvme: fix deadlock caused by ana update wrong locking
Date: Fri, 3 Apr 2020 01:31:15 +0900 [thread overview]
Message-ID: <20200402163115.GA3977@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200402161813.16244-1-sagi@grimberg.me>
On Thu, Apr 02, 2020 at 09:18:13AM -0700, Sagi Grimberg wrote:
> The deadlock combines 4 flows in parallel:
> - ns scanning (triggered from reconnect)
> - request timeout
> - ANA update (triggered from reconnect)
> - I/O coming into the mpath device
>
> (1) ns scanning triggers disk revalidation -> update disk info ->
> freeze queue -> but blocked, due to (2)
>
> (2) timeout handler reference the g_usage_counter - > but blocks in
> the transport .timeout() handler, due to (3)
>
> (3) the transport timeout handler (indirectly) calls nvme_stop_queue() ->
> which takes the (down_read) namespaces_rwsem - > but blocks, due to (4)
>
> (4) ANA update takes the (down_write) namespaces_rwsem -> calls
> nvme_mpath_set_live() -> which synchronize the ns_head srcu
> (see commit 504db087aacc) -> but blocks, due to (5)
>
> (5) I/O came into nvme_mpath_make_request -> took srcu_read_lock ->
> direct_make_request > blk_queue_enter -> but blocked, due to (1)
>
> ==> the request queue is under freeze -> deadlock.
>
> The fix is making ANA update take a read lock as the namespaces list
> is not manipulated, it is just the ns and ns->head (which is protected
> with the ns->head lock.
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Patch looks good to me,
Reviewed-by: Keith Busch <kbusch@kernel.org>
I think this could be a stable candidate, so may want to include a fixes
tag:
Fixes: 0d0b660f214dc ("nvme: add ANA support")
> ---
> drivers/nvme/host/multipath.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
> index 61bf87592570..54603bd3e02d 100644
> --- a/drivers/nvme/host/multipath.c
> +++ b/drivers/nvme/host/multipath.c
> @@ -510,7 +510,7 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,
> if (!nr_nsids)
> return 0;
>
> - down_write(&ctrl->namespaces_rwsem);
> + down_read(&ctrl->namespaces_rwsem);
> list_for_each_entry(ns, &ctrl->namespaces, list) {
> unsigned nsid = le32_to_cpu(desc->nsids[n]);
>
> @@ -521,7 +521,7 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,
> if (++n == nr_nsids)
> break;
> }
> - up_write(&ctrl->namespaces_rwsem);
> + up_read(&ctrl->namespaces_rwsem);
> return 0;
> }
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-04-02 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 16:18 [PATCH] nvme: fix deadlock caused by ana update wrong locking Sagi Grimberg
2020-04-02 16:31 ` Keith Busch [this message]
2020-04-03 6:13 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402163115.GA3977@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).