From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9507C47253 for ; Fri, 1 May 2020 12:49:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87E1B208D6 for ; Fri, 1 May 2020 12:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c7pec+fN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87E1B208D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rmr8lTUVNPCmIJanns4/jSJMYcxvk4vgUjwnKjLt11w=; b=c7pec+fND2sZ2u cgX1iBdZvHdkG8+SoJAwbqpILmpqM9XkkRGIkYO4UzPnlbTPRxIHxKgUxmqDEMyVQYKGmdpVImOgJ Mnf8ccGlTtqcdA4D+4RQUTLF8JyjrRhbXEVAHSjqqBGDYhKRaSLjUrW8AcpHQvcC4MFPJxmU7lzJC jZQyp+EgjPh454rY+TIhtUzra6mkKAnsbbC+MUv+phYoBEAY3rsEbhy2A6cSfz3KAeSvwKRYVgl+p b0lErVOCVT2kAxd7Tbl5/vytzzveQFZVtQJ2BCCiWSkyyi5hB4gnp3VZstxsn8j4ndVR2ool+pFp7 SV1DiW1EvAiA1bMrnzeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUV6j-0001pD-OL; Fri, 01 May 2020 12:49:33 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUV6h-0001oo-UY for linux-nvme@lists.infradead.org; Fri, 01 May 2020 12:49:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7E4A168BFE; Fri, 1 May 2020 14:49:29 +0200 (CEST) Date: Fri, 1 May 2020 14:49:29 +0200 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCH 1/3] nvme-pci: clear shadow doorbell memory on resets Message-ID: <20200501124929.GA5197@lst.de> References: <20200427235243.2268765-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200427235243.2268765-1-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200501_054932_131526_A37DD94F X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 04:52:41PM -0700, Keith Busch wrote: > The host memory doorbell and event buffers need to be initialized on > each reset so the driver doesn't observe stale values from the previous > instantiation. > > Signed-off-by: Keith Busch > --- > drivers/nvme/host/pci.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index cf386c84588b..d388fff9c358 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -228,8 +228,11 @@ static int nvme_dbbuf_dma_alloc(struct nvme_dev *dev) > { > unsigned int mem_size = nvme_dbbuf_size(dev->db_stride); > > - if (dev->dbbuf_dbs) > + if (dev->dbbuf_dbs) { > + memset(dev->dbbuf_dbs, 0, mem_size); > + memset(dev->dbbuf_eis, 0, mem_size); > return 0; Can you throw in a comment why the memory is cleared? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme