From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E1E0C3A5A9 for ; Mon, 4 May 2020 14:08:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3069D20705 for ; Mon, 4 May 2020 14:08:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cc2vkUoG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3069D20705 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W6o6og7em19JROiUg6J2Um6oDgx66ig1gi7ZB0rROdc=; b=Cc2vkUoGM6W1o1 mTk+HB7QVEQxg0+MRSwaUWd+hhQYF2Vdw1vffQZqIAOEyyqsNq/tSydH489MouErHXwCQh7fA8dWj rto3lpD6F7T8gydJHhp/qluFAqC2l18vLo6q3QT6EB1NjrEQCwXjEZaLWQpEQgkA1jv4Lh2Cs7Rnw WjExv9MlGkWnQOufzP6mOiQ2OC/c0QO01eMCbOsicsn9bErSnTyaO27v+Ck4phhzfD9Uh3Tk7TR/a OIWfo3wTMjsjhq4PlWA1opodTLLTlEks9r0JsQAAKomTfSJb75W/CsXhcFoM8FoitUEKLGtBVXOdr sGi3KBHm4fUGOk3ycbKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVblS-0005y5-C4; Mon, 04 May 2020 14:08:10 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVblP-0005wi-Bu for linux-nvme@lists.infradead.org; Mon, 04 May 2020 14:08:08 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5B49768BFE; Mon, 4 May 2020 16:08:01 +0200 (CEST) Date: Mon, 4 May 2020 16:08:00 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 15/15] nvmet-rdma: add metadata/T10-PI support Message-ID: <20200504140800.GA22747@lst.de> References: <20200428131135.211521-1-maxg@mellanox.com> <20200428131135.211521-16-maxg@mellanox.com> <20200501164818.GA19607@lst.de> <5cbfde4a-871e-51d4-bace-b7b0fbd675ba@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5cbfde4a-871e-51d4-bace-b7b0fbd675ba@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_070807_552517_4F48BBAC X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, jsmart2021@gmail.com, sagi@grimberg.me, martin.petersen@oracle.com, shlomin@mellanox.com, israelr@mellanox.com, vladimirk@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, oren@mellanox.com, kbusch@kernel.org, nitzanc@mellanox.com, Christoph Hellwig Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, May 03, 2020 at 07:29:12PM +0300, Max Gurtovoy wrote: >> Can we have a helper for metadata len that also uses >> IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY) to let the compiler garbage collect >> the whole code if it is compiled out? > > We have it in: > > static inline u32 nvmet_rw_metadata_len(struct nvmet_req *req) > { > =A0=A0=A0=A0=A0=A0=A0 if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return 0; > =A0=A0=A0=A0=A0=A0=A0 return ((u32)le16_to_cpu(req->cmd->rw.length) + 1) * > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 req= ->ns->metadata_size; > } > > > and > > req->metadata_len =3D nvmet_rw_metadata_len(req); > > is it good enough for the compiler ? Well, this is the calculated metadata len, not the field in the request, and the compiler can't really know it always is 0 in that case. At some point these optimizations might become a little too ugly, though. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme