From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22F6C433DF for ; Tue, 30 Jun 2020 18:19:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C97C020722 for ; Tue, 30 Jun 2020 18:19:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pa2SpH9+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C97C020722 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zKnC4t6DY3pFf5brCwFIq3Q1AmUEjaBvhnXb9XZuAzM=; b=pa2SpH9+lWqtAHvRJ2dV1L/bf giU8HZyMu6cO6i+w7fO8tSdUMIlovq0yXRvRd5kP5JiT7DToBicgL1RRqd9U5UfRDyfxBBFBwO8Px PHauzhRsu6C1U5T4lniS11SMsJK2TVUPegVNJwcIZUnGNOuNSoji5JLMerisCn75/16qY1ZCZMhzN pzRN2IMSVxy0bVuMDSetTXmsa2GrzWPhP+gNYa6rX3AC668JFs1oAXvsTvIjaoNQtuWVavafrrFbN c6mLzeON0gNS6vROv8bjpju0Werhof0sVvIaEBIaWczd9XJmrHOKtxAFic1UZQE1OADolTeY7ptNF 1fQ045RwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqKr1-0002aH-Vb; Tue, 30 Jun 2020 18:19:36 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqKqy-0002Ze-Tb for linux-nvme@lists.infradead.org; Tue, 30 Jun 2020 18:19:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2C5A868B05; Tue, 30 Jun 2020 20:19:29 +0200 (CEST) Date: Tue, 30 Jun 2020 20:19:28 +0200 From: Christoph Hellwig To: Jens Axboe Subject: Re: rename ->make_request_fn and move it to the block_device_operations Message-ID: <20200630181928.GA7853@lst.de> References: <20200629193947.2705954-1-hch@lst.de> <6ddbe343-0fc2-58c8-3726-c4ba9952994f@kernel.dk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ddbe343-0fc2-58c8-3726-c4ba9952994f@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200630_141933_085523_35FB4C42 X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-bcache@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , drbd-dev@lists.linbit.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2020 at 09:43:31AM -0600, Jens Axboe wrote: > On 6/30/20 7:57 AM, Jens Axboe wrote: > > On 6/29/20 1:39 PM, Christoph Hellwig wrote: > >> Hi Jens, > >> > >> this series moves the make_request_fn method into block_device_operations > >> with the much more descriptive ->submit_bio name. It then also gives > >> generic_make_request a more descriptive name, and further optimize the > >> path to issue to blk-mq, removing the need for the direct_make_request > >> bypass. > > > > Looks good to me, and it's a nice cleanup as well. Applied. > > Dropped, insta-crashes with dm: Hmm. Can you send me what is at "submit_bio_noacct+0x1f6" from gdb? Or your .config? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme