From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: linux-bcache@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, drbd-dev@lists.linbit.com Subject: rename ->make_request_fn and move it to the block_device_operations v2 Date: Wed, 1 Jul 2020 10:59:27 +0200 Message-ID: <20200701085947.3354405-1-hch@lst.de> (raw) Hi Jens, this series moves the make_request_fn method into block_device_operations with the much more descriptive ->submit_bio name. It then also gives generic_make_request a more descriptive name, and further optimize the path to issue to blk-mq, removing the need for the direct_make_request bypass. Changes since v1: - fix a null pointer dereference when dispatching from bio to request based drivers - clean up a few more comments Diffstat: Documentation/block/biodoc.rst | 2 Documentation/block/writeback_cache_control.rst | 2 Documentation/fault-injection/fault-injection.rst | 2 Documentation/trace/ftrace.rst | 4 arch/m68k/emu/nfblock.c | 8 arch/xtensa/platforms/iss/simdisk.c | 9 block/bio.c | 14 - block/blk-cgroup.c | 2 block/blk-core.c | 255 +++++++++------------- block/blk-crypto-fallback.c | 2 block/blk-crypto.c | 2 block/blk-merge.c | 23 - block/blk-mq.c | 12 - block/blk-throttle.c | 4 block/blk.h | 5 block/bounce.c | 2 drivers/block/brd.c | 5 drivers/block/drbd/drbd_int.h | 8 drivers/block/drbd/drbd_main.c | 12 - drivers/block/drbd/drbd_receiver.c | 2 drivers/block/drbd/drbd_req.c | 8 drivers/block/drbd/drbd_worker.c | 2 drivers/block/null_blk_main.c | 19 + drivers/block/pktcdvd.c | 15 - drivers/block/ps3vram.c | 20 - drivers/block/rsxx/dev.c | 14 - drivers/block/umem.c | 11 drivers/block/zram/zram_drv.c | 14 - drivers/lightnvm/core.c | 8 drivers/lightnvm/pblk-init.c | 16 - drivers/lightnvm/pblk-read.c | 2 drivers/md/bcache/bcache.h | 2 drivers/md/bcache/btree.c | 2 drivers/md/bcache/request.c | 11 drivers/md/bcache/request.h | 4 drivers/md/bcache/super.c | 24 +- drivers/md/dm-cache-target.c | 6 drivers/md/dm-clone-target.c | 10 drivers/md/dm-crypt.c | 6 drivers/md/dm-delay.c | 2 drivers/md/dm-era-target.c | 2 drivers/md/dm-integrity.c | 4 drivers/md/dm-mpath.c | 2 drivers/md/dm-raid1.c | 2 drivers/md/dm-snap-persistent.c | 2 drivers/md/dm-snap.c | 6 drivers/md/dm-thin.c | 4 drivers/md/dm-verity-target.c | 2 drivers/md/dm-writecache.c | 2 drivers/md/dm-zoned-target.c | 2 drivers/md/dm.c | 41 +-- drivers/md/md-faulty.c | 4 drivers/md/md-linear.c | 4 drivers/md/md-multipath.c | 4 drivers/md/md.c | 7 drivers/md/raid0.c | 8 drivers/md/raid1.c | 14 - drivers/md/raid10.c | 28 +- drivers/md/raid5.c | 10 drivers/nvdimm/blk.c | 5 drivers/nvdimm/btt.c | 5 drivers/nvdimm/pmem.c | 5 drivers/nvme/host/core.c | 1 drivers/nvme/host/multipath.c | 18 - drivers/nvme/host/nvme.h | 1 drivers/s390/block/dcssblk.c | 11 drivers/s390/block/xpram.c | 8 fs/buffer.c | 5 include/linux/blk-mq.h | 2 include/linux/blkdev.h | 12 - include/linux/lightnvm.h | 3 71 files changed, 387 insertions(+), 408 deletions(-) _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-01 8:59 Christoph Hellwig [this message] 2020-07-01 8:59 ` [PATCH 01/20] nfblock: stop using ->queuedata Christoph Hellwig 2020-07-01 8:59 ` [PATCH 02/20] simdisk: " Christoph Hellwig 2020-07-01 8:59 ` [PATCH 03/20] drbd: " Christoph Hellwig 2020-07-01 8:59 ` [PATCH 04/20] null_blk: stop using ->queuedata for bio mode Christoph Hellwig 2020-07-01 8:59 ` [PATCH 05/20] ps3vram: stop using ->queuedata Christoph Hellwig 2020-07-01 8:59 ` [PATCH 06/20] rsxx: " Christoph Hellwig 2020-07-01 8:59 ` [PATCH 07/20] umem: " Christoph Hellwig 2020-07-01 8:59 ` [PATCH 08/20] zram: " Christoph Hellwig 2020-07-01 8:59 ` [PATCH 09/20] bcache: stop setting ->queuedata Christoph Hellwig 2020-07-02 14:47 ` Coly Li 2020-07-01 8:59 ` [PATCH 10/20] dm: stop using ->queuedata Christoph Hellwig 2020-07-01 17:24 ` Mike Snitzer 2020-07-01 8:59 ` [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc Christoph Hellwig 2020-07-01 8:59 ` [PATCH 12/20] block: remove the request_queue argument from blk_queue_split Christoph Hellwig 2020-07-02 6:14 ` Song Liu 2020-07-01 8:59 ` [PATCH 13/20] block: tidy up a warning in bio_check_ro Christoph Hellwig 2020-07-01 8:59 ` [PATCH 14/20] block: remove the NULL queue check in generic_make_request_checks Christoph Hellwig 2020-07-01 8:59 ` [PATCH 15/20] block: remove the nr_sectors variable " Christoph Hellwig 2020-07-01 8:59 ` [PATCH 16/20] block: move ->make_request_fn to struct block_device_operations Christoph Hellwig 2020-07-01 16:08 ` Dan Williams 2020-07-02 14:48 ` Coly Li 2020-07-01 8:59 ` [PATCH 17/20] block: rename generic_make_request to submit_bio_noacct Christoph Hellwig 2020-07-02 14:51 ` Coly Li 2020-07-02 18:22 ` Song Liu 2020-07-01 8:59 ` [PATCH 18/20] block: refator submit_bio_noacct Christoph Hellwig 2020-07-01 8:59 ` [PATCH 19/20] block: shortcut __submit_bio_noacct for blk-mq drivers Christoph Hellwig 2020-07-01 8:59 ` [PATCH 20/20] block: remove direct_make_request Christoph Hellwig 2020-07-01 13:43 ` rename ->make_request_fn and move it to the block_device_operations v2 Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200701085947.3354405-1-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=drbd-dev@lists.linbit.com \ --cc=linux-bcache@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@lists.linux-m68k.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-xtensa@linux-xtensa.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-NVME Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \ linux-nvme@lists.infradead.org public-inbox-index linux-nvme Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme AGPL code for this site: git clone https://public-inbox.org/public-inbox.git