From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH V2 0/2] nvme: replace linked list with xarray for ns tracking
Date: Wed, 1 Jul 2020 06:21:37 -0700 [thread overview]
Message-ID: <20200701132137.GA1988944@dhcp-10-100-145-180.wdl.wdc.com> (raw)
In-Reply-To: <20200701053609.GA28056@lst.de>
On Wed, Jul 01, 2020 at 07:36:09AM +0200, Christoph Hellwig wrote:
> On Tue, Jun 30, 2020 at 07:25:15PM -0700, Chaitanya Kulkarni wrote:
> > Hi,
> >
> > This is a small patch-series which replaces ctrl->namespaces with
> > xarray for host-core and target-core. We can see following
> > performance improvement when running fio with 32 parallel jobs where
> > first 16 namespaces and last 16 namespaces are used for I/O. See [1] for
> > detailed performance numbers.
>
> Why would that make any difference given that we don't look up namespaces
> in the I/O path?
Not in host side. Target does a lookup on each IO through:
nvmet_req_init()
nvmet_parse_io_cmrd()
nvmet_find_namespaces()
And this detail should be mentioned in the test setup for the cover
letter, or in patch 2.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-07-01 13:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 2:25 [PATCH V2 0/2] nvme: replace linked list with xarray for ns tracking Chaitanya Kulkarni
2020-07-01 2:25 ` [PATCH V2 1/2] nvme-core: use xarray for ctrl " Chaitanya Kulkarni
2020-07-01 13:12 ` Christoph Hellwig
2020-07-01 16:44 ` Keith Busch
2020-07-01 18:19 ` Chaitanya Kulkarni
2020-07-01 18:29 ` Keith Busch
2020-07-01 18:40 ` Chaitanya Kulkarni
2020-07-01 2:25 ` [PATCH V2 2/2] nvmet: use xarray for ctrl ns storing Chaitanya Kulkarni
2020-07-01 6:08 ` Christoph Hellwig
2020-07-01 18:36 ` Chaitanya Kulkarni
2020-07-01 5:36 ` [PATCH V2 0/2] nvme: replace linked list with xarray for ns tracking Christoph Hellwig
2020-07-01 13:21 ` Keith Busch [this message]
2020-07-01 16:49 ` Sagi Grimberg
2020-07-01 18:43 ` Chaitanya Kulkarni
2020-07-01 18:41 ` Chaitanya Kulkarni
2020-07-01 18:41 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701132137.GA1988944@dhcp-10-100-145-180.wdl.wdc.com \
--to=kbusch@kernel.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).