From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: hch@lst.de, kbusch@kernel.org, sagi@grimberg.me
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-nvme@lists.infradead.org
Subject: [PATCH V2 0/2] nvme: fix iod size calculation in nvme_probe()
Date: Thu, 9 Jul 2020 16:40:23 -0700 [thread overview]
Message-ID: <20200709234025.10673-1-chaitanya.kulkarni@wdc.com> (raw)
Hi,
This is a small patch series which fixes the IO size calulation in the
nvme_probe.
The first patch replaces the ctrl->page_size with a macro. The second
patch calculates the maximum value based on NVMe PRP and SGL size.
I've tested this patch with different block sizes 4k-128k on NVMe QEMU
and NVMe PCIe (non-SGL) controller.
Regards,
Chaitanya
* Changes from V1:-
-------------------
1. Remove the ctrl->page_size and use macro instead.
2. Get rid of the conditional operater and use max_t() for SGL vs PRP
size calulation.
Chaitanya Kulkarni (2):
nvme-core: replace ctrl page size with a macro
nvme-pci: use max of PRP or SGL for iod size
drivers/nvme/host/core.c | 19 +++++--------
drivers/nvme/host/nvme.h | 9 ++++++-
drivers/nvme/host/pci.c | 58 +++++++++++++++++++---------------------
3 files changed, 42 insertions(+), 44 deletions(-)
--
2.26.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2020-07-09 23:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 23:40 Chaitanya Kulkarni [this message]
2020-07-09 23:40 ` [PATCH V2 1/2] nvme-core: replace ctrl page size with a macro Chaitanya Kulkarni
2020-07-10 14:57 ` Keith Busch
2020-07-11 18:20 ` Chaitanya Kulkarni
2020-07-13 7:42 ` Christoph Hellwig
2020-07-14 0:02 ` Chaitanya Kulkarni
2020-07-14 16:44 ` Keith Busch
2020-07-09 23:40 ` [PATCH V2 2/2] nvme-pci: use max of PRP or SGL for iod size Chaitanya Kulkarni
2020-07-13 7:42 ` Christoph Hellwig
2020-07-13 23:59 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709234025.10673-1-chaitanya.kulkarni@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).