* [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO
@ 2020-07-28 5:42 Sagi Grimberg
2020-07-28 10:50 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Sagi Grimberg @ 2020-07-28 5:42 UTC (permalink / raw)
To: linux-nvme, Christoph Hellwig, Keith Busch
We allow NVME_CTRL_DELETING to accept I/O.
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
Christoph, another patch we want to fold into
97e9bb2b27bc ("nvme: fix deadlock in disconnect during scan_work and/or ana_work")
thanks...
drivers/nvme/host/fabrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 2a6c8190eeb7..4ec4829d6233 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -547,7 +547,7 @@ static struct nvmf_transport_ops *nvmf_lookup_transport(
blk_status_t nvmf_fail_nonready_command(struct nvme_ctrl *ctrl,
struct request *rq)
{
- if (ctrl->state != NVME_CTRL_DELETING &&
+ if (ctrl->state != NVME_CTRL_DELETING_NOIO &&
ctrl->state != NVME_CTRL_DEAD &&
!blk_noretry_request(rq) && !(rq->cmd_flags & REQ_NVME_MPATH))
return BLK_STS_RESOURCE;
--
2.25.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO
2020-07-28 5:42 [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO Sagi Grimberg
@ 2020-07-28 10:50 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2020-07-28 10:50 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: Keith Busch, Christoph Hellwig, linux-nvme
On Mon, Jul 27, 2020 at 10:42:01PM -0700, Sagi Grimberg wrote:
> We allow NVME_CTRL_DELETING to accept I/O.
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> Christoph, another patch we want to fold into
> 97e9bb2b27bc ("nvme: fix deadlock in disconnect during scan_work and/or ana_work")
>
> thanks...
Folded, thanks.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 5:42 [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO Sagi Grimberg
2020-07-28 10:50 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).