Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO
@ 2020-07-28  5:42 Sagi Grimberg
  2020-07-28 10:50 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Sagi Grimberg @ 2020-07-28  5:42 UTC (permalink / raw)
  To: linux-nvme, Christoph Hellwig, Keith Busch

We allow NVME_CTRL_DELETING to accept I/O.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
Christoph, another patch we want to fold into
97e9bb2b27bc ("nvme: fix deadlock in disconnect during scan_work and/or ana_work")

thanks...

 drivers/nvme/host/fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 2a6c8190eeb7..4ec4829d6233 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -547,7 +547,7 @@ static struct nvmf_transport_ops *nvmf_lookup_transport(
 blk_status_t nvmf_fail_nonready_command(struct nvme_ctrl *ctrl,
 		struct request *rq)
 {
-	if (ctrl->state != NVME_CTRL_DELETING &&
+	if (ctrl->state != NVME_CTRL_DELETING_NOIO &&
 	    ctrl->state != NVME_CTRL_DEAD &&
 	    !blk_noretry_request(rq) && !(rq->cmd_flags & REQ_NVME_MPATH))
 		return BLK_STS_RESOURCE;
-- 
2.25.1


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO
  2020-07-28  5:42 [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO Sagi Grimberg
@ 2020-07-28 10:50 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2020-07-28 10:50 UTC (permalink / raw)
  To: Sagi Grimberg; +Cc: Keith Busch, Christoph Hellwig, linux-nvme

On Mon, Jul 27, 2020 at 10:42:01PM -0700, Sagi Grimberg wrote:
> We allow NVME_CTRL_DELETING to accept I/O.
> 
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> Christoph, another patch we want to fold into
> 97e9bb2b27bc ("nvme: fix deadlock in disconnect during scan_work and/or ana_work")
> 
> thanks...

Folded, thanks.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28  5:42 [PATCH] nvme-fabrics: fail non-ready command only for NVME_CTRL_DELETING_NOIO Sagi Grimberg
2020-07-28 10:50 ` Christoph Hellwig

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git