From: Keith Busch <kbusch@kernel.org>
To: Chao Leng <lengchao@huawei.com>
Cc: axboe@fb.com, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme-core: introduce the preferential local retry mechanism
Date: Tue, 28 Jul 2020 19:31:08 -0700 [thread overview]
Message-ID: <20200729023108.GB2729664@dhcp-10-100-145-180.wdl.wdc.com> (raw)
In-Reply-To: <eed46cb8-1c6b-b83c-3ef4-bc06c922b214@huawei.com>
On Wed, Jul 29, 2020 at 10:06:43AM +0800, Chao Leng wrote:
>
>
> On 2020/7/28 19:20, Christoph Hellwig wrote:
> > If the callers asks for failfast, the caller will get failfast,
> > period.
> >
> If user issue cmd through ioctrl, nvme core will set cmd_flags:
> REQ_FAILFAST_DRIVER, and then in some scenarios which need retry io
> after a defined time, we will return io error, this is not what we
> expected. So we need introduce the preferential local retry mechanism.
Userspace owns error handling with ioctl passthrough commands. The
interface exists for unfiltered access to the device; the driver will
return status exactly as the device provided it. If userspace wants to
retry an error'ed passthrough, it is free to do so.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-07-29 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 6:06 [PATCH] nvme-core: introduce the preferential local retry mechanism Chao Leng
2020-07-28 11:20 ` Christoph Hellwig
2020-07-29 1:58 ` Chao Leng
2020-07-29 2:06 ` Chao Leng
2020-07-29 2:31 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729023108.GB2729664@dhcp-10-100-145-180.wdl.wdc.com \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).