* [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()
@ 2020-08-02 11:15 Tianjia Zhang
2020-08-02 22:54 ` Chaitanya Kulkarni
2020-08-14 8:17 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Tianjia Zhang @ 2020-08-02 11:15 UTC (permalink / raw)
To: james.smart, kbusch, axboe, hch, sagi, jthumshirn, james_p_freyensee
Cc: tianjia.zhang, linux-kernel, linux-nvme
On an error exit path, a negative error code should be returned
instead of a positive return value.
Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
Cc: James Smart <jsmart2021@gmail.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
drivers/nvme/host/fc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index e999a8c4b7e8..2e06f8f4cff1 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2075,7 +2075,7 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl,
if (fc_dma_mapping_error(ctrl->lport->dev, op->fcp_req.cmddma)) {
dev_err(ctrl->dev,
"FCP Op failed - cmdiu dma mapping failed.\n");
- ret = EFAULT;
+ ret = -EFAULT;
goto out_on_error;
}
@@ -2085,7 +2085,7 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl,
if (fc_dma_mapping_error(ctrl->lport->dev, op->fcp_req.rspdma)) {
dev_err(ctrl->dev,
"FCP Op failed - rspiu dma mapping failed.\n");
- ret = EFAULT;
+ ret = -EFAULT;
}
atomic_set(&op->state, FCPOP_STATE_IDLE);
--
2.26.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()
2020-08-02 11:15 [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Tianjia Zhang
@ 2020-08-02 22:54 ` Chaitanya Kulkarni
2020-08-14 8:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2020-08-02 22:54 UTC (permalink / raw)
To: Tianjia Zhang, james.smart, kbusch, axboe, hch, sagi, jthumshirn,
james_p_freyensee
Cc: tianjia.zhang, linux-kernel, linux-nvme
On 8/2/20 04:22, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart<jsmart2021@gmail.com>
> Signed-off-by: Tianjia Zhang<tianjia.zhang@linux.alibaba.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()
2020-08-02 11:15 [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Tianjia Zhang
2020-08-02 22:54 ` Chaitanya Kulkarni
@ 2020-08-14 8:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-08-14 8:17 UTC (permalink / raw)
To: Tianjia Zhang
Cc: sagi, tianjia.zhang, james.smart, linux-nvme, linux-kernel,
axboe, james_p_freyensee, jthumshirn, kbusch, hch
On Sun, Aug 02, 2020 at 07:15:45PM +0800, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart <jsmart2021@gmail.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-14 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 11:15 [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Tianjia Zhang
2020-08-02 22:54 ` Chaitanya Kulkarni
2020-08-14 8:17 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).