From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: linux-nvme@lists.infradead.org
Cc: logang@deltatee.com, hch@lst.de,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
sagi@grimberg.me
Subject: [PATVH V2 0/3] nvmet: passthru fixes
Date: Thu, 6 Aug 2020 19:20:29 -0700 [thread overview]
Message-ID: <20200807022032.48873-1-chaitanya.kulkarni@wdc.com> (raw)
Hi,
This is a small patch-series that fixes a bug in the passthru
submission path and makes the direct call to blk_mq_free_request().
First patch is prep patch to have labels for each action in the
nvnet_execute_passthru_cmd(), second patch fixes the actual oops,
third patch call blk_mq_free_request() directly.
Regards,
Chaitanya
* Changes from V1:-
-------------------
1. Don't use fail_XXX and be consistent with out_XXX_action as
most of the target code labels.
2. Add a out_put_ns label as a prep patch to have proper error
path handling for each action in passthru cmd setup.
3. Add a out_put_req label for blk_put_request() call and move this
call to first in the error handling code path. Along with the
reported but this also fixes potential Oops if nvme_find_get_ns()
fails in the original code.
4. Add reviewers tag for the blk_mq_free_request() patch.
Chaitanya Kulkarni (3):
nvmet: add ns tear down label for pt-cmd handling
nvmet: fix oops in pt cmd execution
nvmet: call blk_mq_free_request() directly
drivers/nvme/target/passthru.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
--
2.22.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2020-08-07 2:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 2:20 Chaitanya Kulkarni [this message]
2020-08-07 2:20 ` [PATVH V2 1/3] nvmet: add ns tear down label for pt-cmd handling Chaitanya Kulkarni
2020-08-07 4:31 ` Logan Gunthorpe
2020-08-07 17:37 ` Sagi Grimberg
2020-08-07 18:28 ` Chaitanya Kulkarni
2020-08-10 12:36 ` Christoph Hellwig
2020-08-07 2:20 ` [PATVH V2 2/3] nvmet: fix oops in pt cmd execution Chaitanya Kulkarni
2020-08-10 12:36 ` Christoph Hellwig
2020-08-07 2:20 ` [PATVH V2 3/3] nvmet: call blk_mq_free_request() directly Chaitanya Kulkarni
2020-08-10 12:36 ` Christoph Hellwig
2020-08-07 19:30 [PATVH V2 0/3] nvmet: passthru fixes Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807022032.48873-1-chaitanya.kulkarni@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).