From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] nvmet-passthru: Cleanup nvmet_passthru_map_sg()
Date: Thu, 15 Oct 2020 09:56:40 +0200 [thread overview]
Message-ID: <20201015075640.GJ14082@lst.de> (raw)
In-Reply-To: <20201009231816.1524-1-logang@deltatee.com>
On Fri, Oct 09, 2020 at 05:18:16PM -0600, Logan Gunthorpe wrote:
> static int nvmet_passthru_map_sg(struct nvmet_req *req, struct request *rq)
> {
> - int sg_cnt = req->sg_cnt;
> struct scatterlist *sg;
> int op_flags = 0;
> struct bio *bio;
> int i, ret;
>
> + if (req->sg_cnt > BIO_MAX_PAGES)
> + return -EINVAL;
Don't you need to handle larger requests as well? Or at least
limit MDTS?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-15 7:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 23:18 [PATCH] nvmet-passthru: Cleanup nvmet_passthru_map_sg() Logan Gunthorpe
2020-10-13 22:26 ` Sagi Grimberg
2020-10-13 22:38 ` Douglas Gilbert
2020-10-14 0:16 ` Chaitanya Kulkarni
2020-10-14 0:20 ` Logan Gunthorpe
2020-10-14 0:25 ` Chaitanya Kulkarni
2020-10-14 15:47 ` Logan Gunthorpe
2020-10-15 7:56 ` Christoph Hellwig [this message]
2020-10-15 16:01 ` Logan Gunthorpe
2020-10-15 17:24 ` Douglas Gilbert
2020-10-15 18:01 ` Christoph Hellwig
2020-10-15 18:40 ` Logan Gunthorpe
2020-10-16 13:57 ` Christoph Hellwig
2020-10-16 16:49 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015075640.GJ14082@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=dgilbert@interlog.com \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).