Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH libnvme] examples: Add src/ into the include and library path
@ 2020-10-20 12:45 Han Han
  2020-10-20 15:14 ` Keith Busch
  0 siblings, 1 reply; 2+ messages in thread
From: Han Han @ 2020-10-20 12:45 UTC (permalink / raw)
  To: linux-nvme; +Cc: kbusch, Han Han

That will fix the compiling errors like:
     CC telemetry-listen
telemetry-listen.c:21:10: fatal error: libnvme.h: No such file or directory
   21 | #include <libnvme.h>
      |          ^~~~~~~~~~~

Signed-off-by: Han Han <hhan@redhat.com>
---
 examples/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/Makefile b/examples/Makefile
index be867a7..24f8574 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -1,5 +1,5 @@
 CFLAGS ?= -g -O2
-override CFLAGS += -Wall -D_GNU_SOURCE
+override CFLAGS += -Wall -D_GNU_SOURCE -I ../src -L ../src
 
 include ../Makefile.quiet
 
-- 
2.26.2


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH libnvme] examples: Add src/ into the include and library path
  2020-10-20 12:45 [PATCH libnvme] examples: Add src/ into the include and library path Han Han
@ 2020-10-20 15:14 ` Keith Busch
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2020-10-20 15:14 UTC (permalink / raw)
  To: Han Han; +Cc: linux-nvme

On Tue, Oct 20, 2020 at 08:45:31PM +0800, Han Han wrote:
> diff --git a/examples/Makefile b/examples/Makefile
> index be867a7..24f8574 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -1,5 +1,5 @@
>  CFLAGS ?= -g -O2
> -override CFLAGS += -Wall -D_GNU_SOURCE
> +override CFLAGS += -Wall -D_GNU_SOURCE -I ../src -L ../src

I guess the examples assumed the library was installed, but that doesn't
make sense if you're testing within the repo. Patch applied, thank you.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 12:45 [PATCH libnvme] examples: Add src/ into the include and library path Han Han
2020-10-20 15:14 ` Keith Busch

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git