Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues
@ 2020-10-16 21:17 James Smart
  2020-10-19 10:06 ` Hannes Reinecke
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: James Smart @ 2020-10-16 21:17 UTC (permalink / raw)
  To: linux-nvme; +Cc: James Smart

[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]

On reconnect, the code currently does not freeze the controller before
possibly updating the number hw queues for the controller.

Add the freeze before updating the number of hw queues. Note: the queues
are already started and remain started through the reconnect.

Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/nvme/host/fc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index c81ebe94d8fe..7067aaf50bf7 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2885,11 +2885,14 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ctrl)
 	if (ret)
 		goto out_delete_hw_queues;
 
-	if (prior_ioq_cnt != nr_io_queues)
+	if (prior_ioq_cnt != nr_io_queues) {
 		dev_info(ctrl->ctrl.device,
 			"reconnect: revising io queue count from %d to %d\n",
 			prior_ioq_cnt, nr_io_queues);
-	blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
+		nvme_wait_freeze(&ctrl->ctrl);
+		blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
+		nvme_unfreeze(&ctrl->ctrl);
+	}
 
 	return 0;
 
-- 
2.26.2


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 158 bytes --]

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues
  2020-10-16 21:17 [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues James Smart
@ 2020-10-19 10:06 ` Hannes Reinecke
  2020-10-19 14:57 ` Himanshu Madhani
  2020-10-22 13:37 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2020-10-19 10:06 UTC (permalink / raw)
  To: linux-nvme

On 10/16/20 11:17 PM, James Smart wrote:
> On reconnect, the code currently does not freeze the controller before
> possibly updating the number hw queues for the controller.
> 
> Add the freeze before updating the number of hw queues. Note: the queues
> are already started and remain started through the reconnect.
> 
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
>   drivers/nvme/host/fc.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues
  2020-10-16 21:17 [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues James Smart
  2020-10-19 10:06 ` Hannes Reinecke
@ 2020-10-19 14:57 ` Himanshu Madhani
  2020-10-22 13:37 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2020-10-19 14:57 UTC (permalink / raw)
  To: James Smart; +Cc: linux-nvme



> On Oct 16, 2020, at 4:17 PM, James Smart <james.smart@broadcom.com> wrote:
> 
> On reconnect, the code currently does not freeze the controller before
> possibly updating the number hw queues for the controller.
> 
> Add the freeze before updating the number of hw queues. Note: the queues
> are already started and remain started through the reconnect.
> 
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
> drivers/nvme/host/fc.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index c81ebe94d8fe..7067aaf50bf7 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -2885,11 +2885,14 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ctrl)
> 	if (ret)
> 		goto out_delete_hw_queues;
> 
> -	if (prior_ioq_cnt != nr_io_queues)
> +	if (prior_ioq_cnt != nr_io_queues) {
> 		dev_info(ctrl->ctrl.device,
> 			"reconnect: revising io queue count from %d to %d\n",
> 			prior_ioq_cnt, nr_io_queues);
> -	blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
> +		nvme_wait_freeze(&ctrl->ctrl);
> +		blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
> +		nvme_unfreeze(&ctrl->ctrl);
> +	}
> 
> 	return 0;
> 
> -- 
> 2.26.2
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

Looks Good. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues
  2020-10-16 21:17 [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues James Smart
  2020-10-19 10:06 ` Hannes Reinecke
  2020-10-19 14:57 ` Himanshu Madhani
@ 2020-10-22 13:37 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-10-22 13:37 UTC (permalink / raw)
  To: James Smart; +Cc: linux-nvme

Thanks,

applied.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 21:17 [PATCH] nvme-fc: wait for queues to freeze before calling update_hr_hw_queues James Smart
2020-10-19 10:06 ` Hannes Reinecke
2020-10-19 14:57 ` Himanshu Madhani
2020-10-22 13:37 ` Christoph Hellwig

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git