From: Enzo Matsumiya <ematsumiya@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Keith Busch <keith.busch@wdc.com>,
Daniel Wagner <dwagner@suse.de>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCHv2] nvme/hwmon: rework to avoid devm allocation
Date: Tue, 19 Jan 2021 19:18:49 -0300 [thread overview]
Message-ID: <20210119221849.npokdza7linj5ocd@hyori> (raw)
In-Reply-To: <20210119064318.124415-1-hare@suse.de>
On 01/19, Hannes Reinecke wrote:
>The original design to use device-managed resource allocation
>doesn't really work as the NVMe controller has a vastly different
>lifetime than the hwmon sysfs attributes, causing warning about
>duplicate sysfs entries upon reconnection.
>This patch reworks the hwmon allocation to avoid device-managed
>resource allocation, and uses the NVMe controller as parent for
>the sysfs attributes.
Works fine on my NVMe-oF/TCP setup now. Thanks.
>Cc: Guenter Roeck <linux@roeck-us.net>
>Signed-off-by: Hannes Reinecke <hare@suse.de>
>Tested-by: Daniel Wagner <dwagner@suse.de>
Tested-by: Enzo Matsumiya <ematsumiya@suse.de>
Cheers,
Enzo
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-19 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 6:43 [PATCHv2] nvme/hwmon: rework to avoid devm allocation Hannes Reinecke
2021-01-19 8:03 ` Daniel Wagner
2021-01-19 14:56 ` Guenter Roeck
2021-01-19 19:07 ` Hannes Reinecke
2021-01-20 5:54 ` Guenter Roeck
2021-01-27 16:35 ` Christoph Hellwig
2021-02-09 12:37 ` Daniel Wagner
2021-01-19 22:18 ` Enzo Matsumiya [this message]
2021-02-10 8:11 ` Christoph Hellwig
2021-02-10 12:10 ` Minwoo Im
2021-02-10 13:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119221849.npokdza7linj5ocd@hyori \
--to=ematsumiya@suse.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).