From: Keith Busch <kbusch@kernel.org>
To: Julian Einwag <jeinwag-nvme@marcapo.com>
Cc: "'linux-nvme@lists.infradead.org'" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
Date: Thu, 18 Feb 2021 05:23:34 +0900 [thread overview]
Message-ID: <20210217202334.GB25688@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <38eae52a15c5474dbdf85defcf6a29fa@marcapo.com>
On Wed, Feb 17, 2021 at 07:33:32AM +0000, Julian Einwag wrote:
> The kernel fails to fully detect these SSDs, only the character devices
> are present:
>
> [ 10.785605] nvme nvme0: pci function 0000:04:00.0
> [ 10.876787] nvme nvme1: pci function 0000:81:00.0
> [ 13.198614] nvme nvme0: missing or invalid SUBNQN field.
> [ 13.198658] nvme nvme1: missing or invalid SUBNQN field.
> [ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
> [ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
> [ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues
> [ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues
> [ 13.239627] nvme nvme0: Identify Descriptors failed (8194)
> [ 13.246315] nvme nvme1: Identify Descriptors failed (8194)
>
> Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679
>
> Signed-off-by: Julian Einwag <jeinwag-nvme@marcapo.com>
Looks fine.
Reviewed-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 0045c5edf629..91cefa40543f 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3233,7 +3233,8 @@ static const struct pci_device_id nvme_id_table[] = {
> { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
> .driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
> { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
> - .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> + .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
> + NVME_QUIRK_NO_NS_DESC_LIST, },
> { PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
> .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> { PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
> --
> 2.30.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next parent reply other threads:[~2021-02-17 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <38eae52a15c5474dbdf85defcf6a29fa@marcapo.com>
2021-02-17 20:23 ` Keith Busch [this message]
2021-02-16 12:25 [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST jeinwag-nvme
2021-02-16 17:54 ` Keith Busch
2021-02-24 9:12 ` Christoph Hellwig
2021-03-05 7:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217202334.GB25688@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=jeinwag-nvme@marcapo.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).