From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
james.smart@broadcom.com, sagi@grimberg.me
Subject: Re: [PATCH V2 2/8] nvme-core: split init identify into helper
Date: Tue, 9 Mar 2021 11:09:18 +0100 [thread overview]
Message-ID: <20210309100918.GB7372@lst.de> (raw)
In-Reply-To: <20210301020611.18669-3-chaitanya.kulkarni@wdc.com>
I've applied this as-is for now, but here is something that I think we
should fix up:
> if (ctrl->apst_enabled && !prev_apst_enabled)
> dev_pm_qos_expose_latency_tolerance(ctrl->device);
> else if (!ctrl->apst_enabled && prev_apst_enabled)
> dev_pm_qos_hide_latency_tolerance(ctrl->device);
I don't think this belongs into init_identify, as it has nothing to do
with the identify data.
> + ret = nvme_init_identify(ctrl);
> + if (ret)
> + return ret;
> +
> ret = nvme_configure_apst(ctrl);
> if (ret < 0)
> return ret;
OTOH it would make a whole lot sense in nvme_configure_apst.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-09 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 2:06 [PATCH V2 0/8] nvme: few cleanups and small improvements Chaitanya Kulkarni
2021-03-01 2:06 ` [PATCH V2 1/8] nvme-core: rename nvme_init_identify() Chaitanya Kulkarni
2021-03-01 2:06 ` [PATCH V2 2/8] nvme-core: split init identify into helper Chaitanya Kulkarni
2021-03-09 10:09 ` Christoph Hellwig [this message]
2021-03-01 2:06 ` [PATCH V2 3/8] nvme-core: mark nvme_setup_passsthru() inline Chaitanya Kulkarni
2021-03-01 2:06 ` [PATCH V2 4/8] nvme-core: use likely in nvme_init_request() Chaitanya Kulkarni
2021-03-09 10:07 ` Christoph Hellwig
2021-03-01 2:06 ` [PATCH V2 5/8] nvme-core: don't check nvme_req flags for new req Chaitanya Kulkarni
2021-03-01 2:06 ` [PATCH V2 6/8] nvme-fc: fix the function documentation comment Chaitanya Kulkarni
2021-03-01 19:09 ` James Smart
2021-03-01 2:06 ` [PATCH V2 7/8] nvmet-fc: update function documentation Chaitanya Kulkarni
2021-03-01 19:10 ` James Smart
2021-03-01 2:06 ` [PATCH V2 8/8] nvme-core: add new line after variable declatation Chaitanya Kulkarni
2021-03-09 10:09 ` [PATCH V2 0/8] nvme: few cleanups and small improvements Christoph Hellwig
2021-03-09 19:42 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309100918.GB7372@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).