From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0F5C433E0 for ; Mon, 15 Mar 2021 10:10:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86E3F64E20 for ; Mon, 15 Mar 2021 10:10:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86E3F64E20 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=LZWxLRNsBa6EhE6iHd82mUNo5FaOa0nUr2/SPmwepqg=; b=gZePa47oUFUgYxrx1nrFUTs+8i zj8W5AQcnLtfHjptn6T5A6s3SdKOCNAVkyT4befVrqf3e4AGfI/Jn7yRi8aken/wRcPkgUxduL+aF RaxV+SfbwhKvIEU/p+qLlitpUKunNoYNF8hnMWVhtzrsEa1t62wiLh6jlu4i8xlUdwZDv7R9rmuek oxfWxGQT4YxsFsh/l+jmt5RD1/I7I+6B4q5w2yQ906/J1kHwONOFRUeFtxXrZExPLRmn64FlSW7+q /eDO6S1qY5ehOWe83HnFwHWJ7W/AXCORP6a3qa7oNnH0dSp7A6eQYYQh1XjrZlbNeagHWducKy9V4 ejYAWebQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLkAX-00FUey-PP; Mon, 15 Mar 2021 10:09:50 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLkAS-00FUdc-8f for linux-nvme@lists.infradead.org; Mon, 15 Mar 2021 10:09:46 +0000 Received: by mail-pg1-x52b.google.com with SMTP id o10so20172341pgg.4 for ; Mon, 15 Mar 2021 03:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Xjxz7T7FKCNoP/ooGZ5ryoM5GFAU3/9+k7o+wjXhrVw=; b=lAMovr6GQ0+cA2UoJCJBdsf+W2wwVH8YGDsefc3jb+yEMvKgtPYlkBSKfilWKKM9xd BfL+0vEnd6VYztUNciFcNG7di9KTHJngOW255oS581KO3nnEfvrUJEW/TqwALKqjks34 EzJhYwTpIt6CILPOX0GoJhfgfVgbp3LmUh1ouZWvJ8Lp5cDP/NfZJYV8oeKsbvCYUjS1 xcuFWyI9j0gQNcE40KUOiEXmz6lAtm1XCjW/RlMD/SgzNdJWNrcDkq8uPM/UxdD1rj31 HU8zW/HiGa6ZVYQSDNA4N1pAtcp/WtNdQnntzA9HQNf+J8hFcOykv29424nyvKJtxA6k yEJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Xjxz7T7FKCNoP/ooGZ5ryoM5GFAU3/9+k7o+wjXhrVw=; b=RnioNmlsrJFlYxAAzakmDfzykZAx2f1QZCdpgF89LfdQ0sszUcvXCjCLZWnYngcOtH no3E7h+e+/eyW7I26HQoNZPDP4dAHtd5fF2l0UyKo0a0Ezy73zyyyjYSCcxdVeQnIed3 r0Wdecifno8ZzWpRBsL4Q4Vry/qmrK5zkZypKosgBQgOMpiOxDyc7RL0NnQqU1/zw6NN L89Ir+5mfqODbOXFk9PldQxF+YyUzTPnFlSBnNxYbySXqdvzp2nLEMSoShE5HpwvXocX gIXZnxZYVyDNy3yxBiTi+ZPdE7rEtkkjNk8U/G4LXH1dxZvciWbwEHXhjgyAZERViefk j0fA== X-Gm-Message-State: AOAM530vkWbeWP0P+4WnFeyzhBffCrNLgYN9OGhYVN6NyRG7ejA7V26y 1Tj1gGIk7oSYDsi6vObpn9w= X-Google-Smtp-Source: ABdhPJyB8b3z7UgzqE+mO3JnWbDdIlOqVMT0Xa3wFEUx++/9WMzV6WADP6VfdgQg2AWQ4likNfV5PA== X-Received: by 2002:a63:440e:: with SMTP id r14mr22303231pga.331.1615802982169; Mon, 15 Mar 2021 03:09:42 -0700 (PDT) Received: from mydomain ([61.120.150.74]) by smtp.gmail.com with ESMTPSA id 205sm8357863pfc.201.2021.03.15.03.09.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Mar 2021 03:09:41 -0700 (PDT) From: Hou Pu To: hch@lst.de, sagi@grimberg.me, chaitanya.kulkarni@wdc.com Cc: linux-nvme@lists.infradead.org, Hou Pu , stable@vger.kernel.org Subject: [PATCH] nvmet-tcp: finish receiving before send back response if nvmet_req_init() failed. Date: Mon, 15 Mar 2021 18:09:28 +0800 Message-Id: <20210315100928.87596-1-houpu.main@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_100944_611866_450093A8 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org When receiving a pdu, if nvmet_req_init() failed (for example a ns is not found), the queue->rcv_state could be moved to NVMET_TCP_RECV_DATA by nvmet_tcp_handle_req_failure(). We should return 0 here to continue to consume the possible remaining inline write out data in nvmet_tcp_try_recv_one(). Otherwise, the response to this request would be sent and iov would be freed. Next time in nvmet_tcp_try_recv_one(), we would go to the receiving data phase and the iov is used again. A panic happend with a 5.4 kernel installed as below: [ 169.906573] nvmet_tcp: failed cmd 0000000027717054 id 106 opcode 1, data_len: 1024 [ 169.908131] general protection fault: 0000 [#1] SMP NOPTI [ 169.908884] CPU: 0 PID: 122 Comm: kworker/0:1H Kdump: loaded Tainted: G OE [...] [ 169.910328] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), [...] [ 169.911943] Workqueue: nvmet_tcp_wq nvmet_tcp_io_work [nvmet_tcp] [ 169.912815] RIP: 0010:__memcpy+0x12/0x20 [ 169.913393] Code: e3 97 ff 0f 31 48 c1 e2 20 48 09 d0 48 31 c3 e9 79 ff [...] [ 169.915819] RSP: 0018:ffffc9000026bbc8 EFLAGS: 00010246 [ 169.916547] RAX: ebf4958c4fda661b RBX: ffff888119613096 RCX: 0000000000000080 [ 169.917511] RDX: 0000000000000000 RSI: ffff888119613096 RDI: ebf4958c4fda661b [ 169.918469] RBP: 0000000000000400 R08: 0000000000000000 R09: 0000000000000400 [ 169.919435] R10: 0000000000000000 R11: 000000000000003e R12: ffff888114244068 [ 169.920398] R13: 0000000000000400 R14: 0000000000000400 R15: ffff888118c37cb0 [ 169.921378] FS: 0000000000000000(0000) GS:ffff88813fc00000(0000) knlGS:0000000000000000 [ 169.922473] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 169.923269] CR2: 0000555eb19943e0 CR3: 00000001186fc000 CR4: 00000000000006f0 [ 169.924245] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 169.925214] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 169.926184] Call Trace: [ 169.926569] _copy_to_iter+0x26f/0x440 [ 169.927112] ? __check_object_size+0x70/0x230 [ 169.927724] __skb_datagram_iter+0x15a/0x290 [ 169.928327] ? skb_kill_datagram+0x60/0x60 [ 169.928921] skb_copy_datagram_iter+0x3b/0x90 [ 169.929545] tcp_recvmsg+0x759/0xc50 [ 169.930081] ? ksoftirqd_running+0x2c/0x30 [ 169.930668] ? free_unref_page_commit+0x95/0x120 [ 169.931331] inet_recvmsg+0x55/0xc0 [ 169.931834] nvmet_tcp_io_work+0x685/0xb23 [nvmet_tcp] [ 169.932549] process_one_work+0x18c/0x370 [ 169.933118] worker_thread+0x4f/0x3b0 [ 169.933654] ? rescuer_thread+0x340/0x340 [ 169.934223] kthread+0xf6/0x130 [ 169.934682] ? kthread_create_worker_on_cpu+0x70/0x70 [ 169.935393] ret_from_fork+0x1f/0x30 Cc: # 5.0 Signed-off-by: Hou Pu --- drivers/nvme/target/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index 8b0485ada315..da1c667e21ba 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -961,7 +961,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length)); nvmet_tcp_handle_req_failure(queue, queue->cmd, req); - return -EAGAIN; + return 0; } ret = nvmet_tcp_map_data(queue->cmd); -- 2.28.0 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme