From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83810C433E0 for ; Wed, 17 Mar 2021 06:46:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5B7664F9F for ; Wed, 17 Mar 2021 06:46:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5B7664F9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ICUaSkSnPxsdOBDZhCGnbQ09R4/8mV7szi0Nqw2Kb9s=; b=Tymo80JwtIDKmX/UOdTr4/ieg C2ycw3BhldG37WqFb/lQV+4T8srWUh+snTLbz2/wVLGDeRARg9rmNCrnQKhuqm28lQD1rBrblbAZt YCKF9PhPg2vsULIjk452OINvHohLHFRY7000sufq1/E9yF2cvYNhjUIhxM1majRF0BOhmqWGvIYt8 8b3Z7cuo688O8/IqofhNho9zxxVaZFgbJmqpbri/9Oi/MulRJL8cPelDQkeducUxv3Vzoh5vp1pg4 ZMh8FyaHsStImgE/XcDpiDuN2cfap5gpu+mmM8qVgxcvUo0puy+z69R4Pdgf5S8+SUmlmo+CvMITK JkaYheHOg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMPwc-002aMz-3a; Wed, 17 Mar 2021 06:46:14 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMPwU-002aLV-F5 for linux-nvme@lists.infradead.org; Wed, 17 Mar 2021 06:46:08 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E964F68BEB; Wed, 17 Mar 2021 07:46:00 +0100 (CET) Date: Wed, 17 Mar 2021 07:46:00 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, Kanchan Joshi Subject: Re: [PATCH 1/2] nvme-pci: allocate nvme_command within driver pdu Message-ID: <20210317064600.GA14498@lst.de> References: <20210316170632.4161183-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316170632.4161183-1-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_064606_645572_890F9413 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 10:06:31AM -0700, Keith Busch wrote: > All the nvme transport drivers had allocated the nvme command within the > driver's pdu except for pci. Align pci with everyone else and replace > the stack variable with the pdu command. > > Signed-off-by: Keith Busch Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme