From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0428C433DB for ; Thu, 18 Mar 2021 04:43:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27C0064F40 for ; Thu, 18 Mar 2021 04:43:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27C0064F40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9eJZ0v2/1ISe31LyBHryazU8qQkhxKvTHj00hZ1bMfA=; b=loAIy8nNvwcb66uXtMpnBQX7W /XnCX0Cl65abPxehqBi+IJZmqgFN1MAwmJNb+6HZHSKW3L5FjyRZv6v1WzEjAGvU/n5cH4/BIPxua ksZCTj2gLGUdqBc7sT4HEwWMEf2G2GAtDvsHf7MNXW6BlMFoAAR9E29XwbJIbdu8MxxpzbL3f4zQL 347FrBi2UfuY40o6JxKRzNkC63RTd6/ApkzuxTNII+6ltJUkDi3lmykna9qO76eSQ88cWtKNBn2nB NANOpDj16pqB+cVLUhfiyzLuPlT19wynWTeGHZn0U2NrK83PJewq31vWqtQafWUxdMLY0fJYmD0L8 ecsyFGj3A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMkUq-004QhQ-8d; Thu, 18 Mar 2021 04:43:00 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMkUi-004Qeo-K8 for linux-nvme@lists.infradead.org; Thu, 18 Mar 2021 04:42:53 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5853668C4E; Thu, 18 Mar 2021 05:42:46 +0100 (CET) Date: Thu, 18 Mar 2021 05:42:45 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me Subject: Re: [PATCHv2] nvme: implement non-mdts command limits Message-ID: <20210318044245.GC26988@lst.de> References: <20210317212606.110919-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210317212606.110919-1-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210318_044251_242473_A82A2211 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > static void nvme_config_write_zeroes(struct request_queue *q, > struct nvme_ctrl *ctrl) > { > + blk_queue_max_write_zeroes_sectors(q, ctrl->max_zeroes_sectors); I think at this point we can kill nvme_config_write_zeroes :) > +static int nvme_init_non_mdts_limits(struct nvme_ctrl *ctrl) > +{ > + struct nvme_command c = { }; > + struct nvme_id_ctrl_nvm *id; > + int ret; > + > + if (!(ctrl->oncs & NVME_CTRL_ONCS_DSM)) { > + ctrl->max_discard_sectors = 0; > + ctrl->max_discard_segments = 0; > + } else { > + ctrl->max_discard_sectors = UINT_MAX; > + ctrl->max_discard_segments = NVME_DSM_MAX_RANGES; > + } Can you switch the polarity here, that is avoid the pointless negation in the if? > + if (ctrl->vs < NVME_VS(1, 2, 0)) > + return 0; This check doesn't make much sense to me, as new TPs can always apply to older spec versions as well. Instead this probably should be a nvme_ctrl_limited_cns() check. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme