From: Keith Busch <kbusch@kernel.org>
To: Alan Adamson <alan.adamson@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 0/1] nvme: Export CSTS register via sysfs
Date: Fri, 19 Mar 2021 01:52:13 +0900 [thread overview]
Message-ID: <20210318165213.GA31675@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <0D18CE6C-4390-4040-98A6-14204DE33253@oracle.com>
On Thu, Mar 18, 2021 at 04:28:24PM +0000, Alan Adamson wrote:
>
>
> > On Mar 17, 2021, at 9:38 PM, Christoph Hellwig <hch@lst.de> wrote:
> >
> > On Wed, Mar 17, 2021 at 04:46:14PM -0400, Alan Adamson wrote:
> >> This patch exports the NVMe Controller CSTS register via sysfs. This
> >> feature can be used by userland executables that accessed CSTS and
> >> possibly other registers by mapping them into user space. Since this ability
> >> may not always available, exporting certain registers via sysfs provides
> >> a safe/read-only way to access registers from outside the kernel.
> >
> > So what is this application doings with it? Should we just have a
> > ready attribute instead of exporting a raw register encoding?
>
>
> Was using nvme-cli show-regs to manage nvme devices. This is no longer an option.
Most distributions ship with kernel CONFIG_IO_STRICT_DEVMEM these days,
so that user command will very rarely work on PCIe targets anymore.
Perhaps we could introduce a driver option allowing read-only mmap on
this memory? While you're currently asking for just one register
attribute, it would be nice if we can make all future requests available
without piling on more sysfs properties.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-18 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:46 [PATCH 0/1] nvme: Export CSTS register via sysfs Alan Adamson
2021-03-17 20:46 ` [PATCH 1/1] " Alan Adamson
2021-03-18 1:06 ` [PATCH 0/1] " Chaitanya Kulkarni
2021-03-18 4:38 ` Christoph Hellwig
2021-03-18 14:19 ` Keith Busch
2021-03-18 16:28 ` Alan Adamson
2021-03-18 16:52 ` Keith Busch [this message]
2021-03-18 18:39 ` Alan Adamson
2021-03-18 19:46 ` Keith Busch
2021-03-19 6:51 ` Christoph Hellwig
2021-03-19 15:22 ` Keith Busch
2021-03-19 15:30 ` Christoph Hellwig
2021-03-19 17:21 ` Alan Adamson
2021-03-19 17:30 ` Keith Busch
2021-03-19 17:33 ` Alan Adamson
2021-05-05 18:40 ` Alan Adamson
2021-05-05 20:11 ` Keith Busch
2021-05-05 20:23 ` Alan Adamson
2021-05-05 20:35 ` Keith Busch
2021-03-18 19:15 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318165213.GA31675@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=alan.adamson@oracle.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).