From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D48AC433C1 for ; Tue, 23 Mar 2021 18:23:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64768619C0 for ; Tue, 23 Mar 2021 18:23:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64768619C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XVE7oX6Sn+e9KA0YwoO8lPaT5OnF7mdBDEz8keYkIaM=; b=kuc4Hg4qqU9FGcZM+SN9Skx1r fSXoV2poamehPsiSSMvdpPwYpp67Nco0GA8cWgUCqmF/Adw76FlO0W/nA90BTU1PeVvy+EAGBK+45 Uj65ChKynfvdqRl0rrExpRMOEOVQUBzrReqpmngNCVR8//1dXWlGkO2ue9kH/0fjwc3nRJBJQJkNw n2uOiLs8DJ7RtGY46iVjaroSmpOx+Xvl9LGmJjVjXTuqsV6gz9miIn2euvet8jHt9iAgZjNhndj5w iXPY0371IK6802bNQGqhfwxYwdKxs2Ij0u6aLcbYrCMAAGF1HMlt6hoL0jIsDh0YJcj2MWNAvY4rB G5TfmbX3Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOlg2-00FVc0-8I; Tue, 23 Mar 2021 18:22:50 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOlfz-00FVbA-8F for linux-nvme@lists.infradead.org; Tue, 23 Mar 2021 18:22:48 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id C958A68B02; Tue, 23 Mar 2021 19:22:44 +0100 (CET) Date: Tue, 23 Mar 2021 19:22:44 +0100 From: Christoph Hellwig To: Sagi Grimberg Cc: Christoph Hellwig , Chao Leng , Keith Busch , Jens Axboe , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 2/2] nvme-multipath: don't block on blk_queue_enter of the underlying device Message-ID: <20210323182244.GA16649@lst.de> References: <20210322073726.788347-1-hch@lst.de> <20210322073726.788347-3-hch@lst.de> <34e574dc-5e80-4afe-b858-71e6ff5014d6@grimberg.me> <33ec8b12-0b2b-e934-acb1-aae8d0259e2e@grimberg.me> <31e7f7f4-55fa-6b0c-426d-7f7e7638ab4b@huawei.com> <5d28226d-4619-74b6-1c73-c13ed57aa7ea@grimberg.me> <20210323161544.GA13402@lst.de> <162dc8f7-b46d-37ff-01e8-51d813e0a904@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <162dc8f7-b46d-37ff-01e8-51d813e0a904@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_182247_501079_E62933B1 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Mar 23, 2021 at 11:13:13AM -0700, Sagi Grimberg wrote: > The deadlock in this patchset reproduces upstream. It is not possible to > update the kernel in the env in the original report. > > So IFF we assume that this does not reproduce in upstream (pending > proof), is there something that we can do with stable fixes? This will > probably go back to everything that is before 5.8... The direct_make_request removal should be pretty easily backportable. In old kernels without the streamlined normal path it might cause minor performance degradations, but the actual change should be trivial. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme