From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BEA6C433B4 for ; Fri, 9 Apr 2021 14:35:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C33AD61006 for ; Fri, 9 Apr 2021 14:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C33AD61006 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DUeeLARlfw2HaU8J/bDpSp13iIKnlE77kh8M8YuuFMs=; b=WjdDeztdAmGt9rvscoWQRz6mY wCNJJDYFBnwCipP+SIiw2jwhGjA0sjtWUzL6JqOHlNhtDn/FSOnlpL2qdP7E9ke90qE2SN6sxqLOO P5pcR7qCmoutu/ZLh2xAbS5m1B71l9iBqRbBQ3fB7krsPf5hlcFDR2dlyjkZua7thNoLSiDwwuoVt 64k/0oa+qh3xaoE41Td5Q9kqStHSIFOAZSJSulv2DmgTrYw3wttQT/uQnll7Sjm8c7WKkKfOyCYrg nBxmKpOCTUVVhoSrAsPbO2VR4phRzXKfkbzl9FoEikNJpDzBFkgpvqTgmr42qoOF8EWEtutPdlLiN E0YiLog2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUsEL-000vQr-CY; Fri, 09 Apr 2021 14:35:29 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUsEF-000vPU-8T for linux-nvme@lists.infradead.org; Fri, 09 Apr 2021 14:35:26 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A1B7E67373; Fri, 9 Apr 2021 16:35:20 +0200 (CEST) Date: Fri, 9 Apr 2021 16:35:20 +0200 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Minwoo Im , Sagi Grimberg , Kanchan Joshi , Javier Gonz??lez , linux-nvme@lists.infradead.org Subject: Re: [PATCH 13/13] nvme: introduce generic per-namespace chardev Message-ID: <20210409143520.GA6007@lst.de> References: <20210408120842.1450092-1-hch@lst.de> <20210408120842.1450092-14-hch@lst.de> <20210408165613.GA3774@redsun51.ssa.fujisawa.hgst.com> <20210409061432.GA3702@lst.de> <20210409142927.GA6929@C02WT3WMHTD6> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210409142927.GA6929@C02WT3WMHTD6> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_153523_690435_ECC6E8AB X-CRM114-Status: GOOD ( 11.95 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Apr 09, 2021 at 08:29:27AM -0600, Keith Busch wrote: > Right, my mistake. > > In that case, there needs to be a ida_simple_remove() after the > cdev_device_del() so we don't leak the ida. Yes, I actually noticed that while I looked into your idea. As of this morning my local tree has a helper that does the cdev_device_del and the ida_simple_remove in one go. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme