linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: hch@lst.de, kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
	chaitanya.kulkarni@wdc.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme: avoid memset for passthrough requests
Date: Wed, 14 Apr 2021 08:08:12 +0200	[thread overview]
Message-ID: <20210414060812.GA24949@lst.de> (raw)
In-Reply-To: <20210414051629.103383-3-joshi.k@samsung.com>

On Wed, Apr 14, 2021 at 10:46:29AM +0530, Kanchan Joshi wrote:
> nvme_clear_nvme_request() clears the nvme_command, which is unncessary for
> passthrough requests as nvme_command is overwritten immediately.
> Change nvme_clear_nvme_request() so that double memset for passthrough
> requests is avoided.

Please just move the memset to the one caller that wants ->cmd zeroed.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-04-14  6:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210414051733epcas5p31d0a4727a2c05b76bcf7ee75c290aaef@epcas5p3.samsung.com>
2021-04-14  5:16 ` [PATCH 0/2] kref and paasthrough cleanup Kanchan Joshi
     [not found]   ` <CGME20210414051743epcas5p3f5371b68b066e5093d91f598b0803e9c@epcas5p3.samsung.com>
2021-04-14  5:16     ` [PATCH 1/2] nvme: add nvme_get_ns helper Kanchan Joshi
     [not found]   ` <CGME20210414051747epcas5p265826317a971aaa3337efb6472a9df7c@epcas5p2.samsung.com>
2021-04-14  5:16     ` [PATCH 2/2] nvme: avoid memset for passthrough requests Kanchan Joshi
2021-04-14  6:08       ` Christoph Hellwig [this message]
2021-04-14 16:27         ` Kanchan Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414060812.GA24949@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).