From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9992DC433ED for ; Wed, 14 Apr 2021 14:21:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F7A361019 for ; Wed, 14 Apr 2021 14:21:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F7A361019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FT21s2+6pagGiipPRlptzjTvXYfPg0yVom01omWt0dc=; b=lmKs5b7iSSuDhJgLYMx1PiGft /rzvcfDdAe0SsthAHOXY+Z8+Sof3AiFz5U8u+3yqoeMvdJSB1h35faSj0vsfbb9XZNQUCZ40+QV1J M56fOcbct45cArMXF+yv7l2LOy64i1x7u7y3Rh1tq8lfmaV72/zX8AYrTQd00SXq3zDGZTwAPC/uu 4Qv5UmGqiaR33pS+zNW19RalBvJQdVtjzHymzIZzcrxPoXuZdNourUajcP0GgvkwuHTp3xZgID3Hf f7vW92GP5at0EEZC6/Hr5APtnJZZRNZ8AHq8ueKZFYo8C1bwlWzBRvwsjymQo35SehKAJsnpv7Pvy BJ1yNYHdg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWgO2-00CsMN-Jy; Wed, 14 Apr 2021 14:20:59 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWgNv-00CsLV-FY for linux-nvme@desiato.infradead.org; Wed, 14 Apr 2021 14:20:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oJTqMzs1p5nJY3V2EhXqx+dlaQEB5ZJ+GqWcO2O7uGQ=; b=BvolqTzoJlIEIV+P/unbiGddCz MSP+InxO/UYsjt7R4MWjzM3rt3yAkO4yRRxV9r8QtR57YhBme6i8R4v1BUh52l91GHR+f55uRksM6 zj+TS6Qt/KCj4wE8KqkZs9j2BpFmj7/zH6YBW2UYC85vx31r3f+sFRe22d15mRu+Y8pYQukQRSCD1 uOuAaXnC9IKgH/LxCl+xnjTSPtEBusfq52xOn0auY1nYy9iu/tGINspF9mmsJ7RmcJQRfz67xy2wo PGlcsX3r4hQHbLOshAcj6Ebn9RK2hSbmoFlMNrIbE3mZ1jeNtbthJepPivYtumkAadXj9kFodH//N rG7PqTNg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWgHR-007osC-EG for linux-nvme@lists.infradead.org; Wed, 14 Apr 2021 14:14:10 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E07261179; Wed, 14 Apr 2021 14:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618409639; bh=DxWBDI4/jzx7gEZbqcY7Ls7rwUHmhHab9VL7viZiFtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SqtLHCzFVVX95a47dTrw15vW8xlNtk1ATynECyXqor+qrS+f28D8QKG5Ux4m+yUGn vt/0wt8KlxCr6thf2Cfyzw4Uq2Rw5uyglaeZdFBuBbeJCvQa2/LSu8AcVdgfNLhOCB byiE2649w6CEF7V42wSyMaZdHXK74zZExg60pVbTGVtT6fQH/C47A2k3/I7Vj8LuVF j3tRwTSylWSNc1mqvVQUlU1eKURveygeDXXG21+RP4fk2KJ5vwHbbukvwwlECyZeXM 1knwfo6LCUDXtWXIxaJFCKxR2Dm3zEH3bDqL1YDala7XS59jb00xBSC8wNzPpzQQ8z 2Tcu3mTzbYQeg== Date: Wed, 14 Apr 2021 07:13:57 -0700 From: Keith Busch To: Gopal Tiwari Cc: linux-nvme@lists.infradead.org Subject: Re: [PATCH] Fix NULL derefence in nvme_ctrl_fast_io_fail_tmo_show/store Message-ID: <20210414141357.GB2448507@dhcp-10-100-145-180.wdc.com> References: <20210414084645.638150-1-gtiwari@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210414084645.638150-1-gtiwari@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_071409_527613_8B9D324F X-CRM114-Status: UNSURE ( 7.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Apr 14, 2021 at 02:16:45PM +0530, Gopal Tiwari wrote: > Adding entry for dev_attr_fast_io_fail_tmo to avoid the kernel crash > while reading and writing the fast_io_fail_tmo. > > Fixes: 09fbed636382 (nvme: export fast_io_fail_tmo to sysfs) Looks good. Reviewed-by: Keith Busch _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme