From: Keith Busch <kbusch@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org,
Daniel Wagner <daniel.wagner@suse.de>
Subject: Re: [PATCHv2] nvme-mpath: delete disk after last connection
Date: Tue, 20 Apr 2021 23:16:10 +0900 [thread overview]
Message-ID: <20210420141610.GB14300@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20210416062411.47958-1-hare@suse.de>
On Fri, Apr 16, 2021 at 08:24:11AM +0200, Hannes Reinecke wrote:
> Now delete all paths to one of the namespaces:
>
> # echo 1 > /sys/class/nvme/nvme3/delete_controller
> # echo 1 > /sys/class/nvme/nvme4/delete_controller
>
> We have no path, but mdstat says:
>
> # cat /proc/mdstat
> Personalities : [raid1]
> md0 : active (auto-read-only) raid1 nvme5n1[1]
> 64512 blocks super 1.2 [2/1] [_U]
>
> And this is reported to cause a problem.
>
> With the proposed patch, the following messages appear:
>
> [ 227.516807] md/raid1:md0: Disk failure on nvme3n1, disabling device.
> [ 227.516807] md/raid1:md0: Operation continuing on 1 devices.
>
> And mdstat shows only the viable members:
>
> # cat /proc/mdstat
> Personalities : [raid1]
> md0 : active (auto-read-only) raid1 nvme5n1[1]
> 64512 blocks super 1.2 [2/1] [_U]
I think there's a copy-paste error in this change log (probably my
mistake). The first mdstat should have shown nvme3n1 was still there,
right?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-20 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 6:24 [PATCHv2] nvme-mpath: delete disk after last connection Hannes Reinecke
2021-04-20 8:05 ` Christoph Hellwig
[not found] ` <91f25f95-e5a0-466f-b410-6f6dafdec0a0@email.android.com>
2021-04-20 9:54 ` Christoph Hellwig
2021-04-20 13:19 ` Hannes Reinecke
2021-04-20 14:14 ` Keith Busch
2021-04-20 14:39 ` Christoph Hellwig
2021-04-20 17:02 ` Hannes Reinecke
2021-04-20 17:16 ` Keith Busch
2021-04-20 20:05 ` Martin Wilck
2021-04-20 16:21 ` Hannes Reinecke
2021-04-20 14:16 ` Keith Busch [this message]
2021-05-01 11:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420141610.GB14300@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=daniel.wagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).