archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <>
To: James Smart <>
	James Smart <>,
	Keith Busch <>, Jens Axboe <>,
	Ming Lei <>, Sagi Grimberg <>
Subject: Re: [PATCH v2 5/5] nvme-fc: Freeze queues before destroying them
Date: Fri, 9 Jul 2021 18:42:57 +0200	[thread overview]
Message-ID: <20210709164257.hzbxrbgjnnooidqe@beryllium.lan> (raw)
In-Reply-To: <>

Hi James,

On Fri, Jul 09, 2021 at 09:14:07AM -0700, James Smart wrote:
> Thanks for the note. that definitely helped follow what is being attempted.
> I also agree with Hannes that the comment from the rdma patch should also be
> present to understand what's going on.

Sure will do. Though this has to wait until I am back from holiday
though :)

> Looking at the patch - this is not done in the same place or manner as rdma.
> Freezing and stoppage is prior to cancelling and that doesn't correspond
> where this was added (this is after all cancellations). We also seem to be
> missing a nvme_sync_io_queues() call in the sequence as well. So I believe
> there's more work to be done on this patch.  I'll see what I can do.


> We really need to see about a common layer for transports. So much we do is
> similar. We were ok at the start, but we've drifted apart over time and the
> requirements to the core layer aren't propogating to all transports.

Yes, makes a lot of sense to me to sync the transports implementation a
bit more.


Linux-nvme mailing list

      reply	other threads:[~2021-07-09 16:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  9:27 [PATCH v2 0/5] Handle update hardware queues and queue freeze more carefully Daniel Wagner
2021-07-08  9:27 ` [PATCH v2 1/5] nvme-fc: Update hardware queues before using them Daniel Wagner
2021-07-08 10:08   ` Hannes Reinecke
2021-07-08  9:27 ` [PATCH v2 2/5] nvme-tcp: Update number of " Daniel Wagner
2021-07-08  9:27 ` [PATCH v2 3/5] nvme-rdma: " Daniel Wagner
2021-07-08  9:27 ` [PATCH v2 4/5] nvme-fc: Wait with a timeout for queue to freeze Daniel Wagner
2021-07-08 10:12   ` Hannes Reinecke
2021-07-08  9:27 ` [PATCH v2 5/5] nvme-fc: Freeze queues before destroying them Daniel Wagner
2021-07-08 10:14   ` Hannes Reinecke
2021-07-09 16:14   ` James Smart
2021-07-09 16:42     ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709164257.hzbxrbgjnnooidqe@beryllium.lan \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).