From: Daniel Wagner <dwagner@suse.de> To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, James Smart <james.smart@broadcom.com>, Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>, Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>, Wen Xiong <wenxiong@us.ibm.com>, Daniel Wagner <dwagner@suse.de> Subject: [PATCH RESEND v4 0/8] Handle update hardware queues and queue freeze more carefully Date: Mon, 2 Aug 2021 13:26:50 +0200 [thread overview] Message-ID: <20210802112658.75875-1-dwagner@suse.de> (raw) [forgot to add the linux-nvme mailing list] Hi, This update version makes sure the unfreeze call is done when recreating the queues. I was able to reproduce hanging I/Os when we go into error recovery mode for FC and TCP [1]. Unfortunatly, I don't have access to a RDMA setup to verify but as the code is identically to the TCP, RDMA looks to like to suffer from the same problem. Thanks, Daniel [1] https://lore.kernel.org/linux-nvme/20210730094907.5vg7qebggttibogz@beryllium.lan/ https://lore.kernel.org/linux-nvme/20210730113415.wezsrvxv5cu4yz4x@beryllium.lan/ v1: - https://lore.kernel.org/linux-nvme/20210625101649.49296-1-dwagner@suse.de/ v2: - https://lore.kernel.org/linux-nvme/20210708092755.15660-1-dwagner@suse.de/ - reviewed tags collected - added 'update hardware queues' for all transport - added fix for fc hanger in nvme_wait_freeze_timeout v3: - https://lore.kernel.org/linux-nvme/20210720124353.127959-1-dwagner@suse.de/ - dropped 'nvme-fc: Freeze queues before destroying them' - added James' two patches v4: - added 'nvme-*: Unfreeze queues on reconnect' - added Hannes' reviewed tags Daniel Wagner (5): nvme-fc: Update hardware queues before using them nvme-rdma: Update number of hardware queues before using them nvme-fc: Wait with a timeout for queue to freeze nvme-tcp: Unfreeze queues on reconnect nvme-rdma: Unfreeze queues on reconnect Hannes Reinecke (1): nvme-tcp: Update number of hardware queues before using them James Smart (2): nvme-fc: avoid race between time out and tear down nvme-fc: fix controller reset hang during traffic drivers/nvme/host/fc.c | 28 +++++++++++++++++++--------- drivers/nvme/host/rdma.c | 15 ++++++++------- drivers/nvme/host/tcp.c | 18 +++++++++--------- 3 files changed, 36 insertions(+), 25 deletions(-) -- 2.29.2 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-08-02 11:28 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-02 11:26 Daniel Wagner [this message] 2021-08-02 11:26 ` [PATCH v4 1/8] nvme-fc: Update hardware queues before using them Daniel Wagner 2021-08-02 19:34 ` Himanshu Madhani 2021-08-02 11:26 ` [PATCH v4 2/8] nvme-tcp: Update number of " Daniel Wagner 2021-08-06 19:57 ` Sagi Grimberg 2021-08-09 8:52 ` Daniel Wagner 2021-08-11 1:00 ` Sagi Grimberg 2021-08-11 1:07 ` Keith Busch 2021-08-11 5:57 ` Sagi Grimberg 2021-08-11 10:25 ` Daniel Wagner 2021-08-02 11:26 ` [PATCH v4 3/8] nvme-rdma: " Daniel Wagner 2021-08-02 11:26 ` [PATCH v4 4/8] nvme-fc: Wait with a timeout for queue to freeze Daniel Wagner 2021-08-02 19:36 ` Himanshu Madhani 2021-08-02 11:26 ` [PATCH v4 5/8] nvme-fc: avoid race between time out and tear down Daniel Wagner 2021-08-02 19:38 ` Himanshu Madhani 2021-08-02 11:26 ` [PATCH v4 6/8] nvme-fc: fix controller reset hang during traffic Daniel Wagner 2021-08-02 19:39 ` Himanshu Madhani 2021-08-04 7:23 ` Hannes Reinecke 2021-08-04 8:08 ` Daniel Wagner 2021-08-11 1:05 ` Sagi Grimberg 2021-08-11 10:30 ` Daniel Wagner 2021-08-12 20:03 ` James Smart 2021-08-18 11:43 ` Daniel Wagner 2021-08-18 11:49 ` Daniel Wagner 2021-08-02 11:26 ` [PATCH v4 7/8] nvme-tcp: Unfreeze queues on reconnect Daniel Wagner 2021-08-02 11:26 ` [PATCH v4 8/8] nvme-rdma: " Daniel Wagner 2021-08-04 7:25 ` Hannes Reinecke 2021-08-06 19:59 ` Sagi Grimberg 2021-08-09 8:58 ` Daniel Wagner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210802112658.75875-1-dwagner@suse.de \ --to=dwagner@suse.de \ --cc=hare@suse.de \ --cc=james.smart@broadcom.com \ --cc=kbusch@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=ming.lei@redhat.com \ --cc=sagi@grimberg.me \ --cc=wenxiong@us.ibm.com \ --subject='Re: [PATCH RESEND v4 0/8] Handle update hardware queues and queue freeze more carefully' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).