From: Anton Eidelman <anton@lightbitslabs.com>
To: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
sagi@grimberg.me, axboe@fb.com
Cc: Anton Eidelman <anton@lightbitslabs.com>
Subject: [PATCH 0/3] nvme/mpath: fix missed namespaces in ana state update
Date: Sat, 11 Sep 2021 19:07:28 -0600 [thread overview]
Message-ID: <20210912010731.471859-1-anton@lightbitslabs.com> (raw)
Fixed two issues in nvme_update_ana_state() that caused ana_work
to miss existing namespaces and consequently a failure to update
the namespace ANA state based on the ANA log page.
1) A plain bug: we skipped an nsid in desc->nsids in a certain
combination of nsids present and nsids reports in the ANA log,
and failed to match this nsid to an existing namespace.
2) Unhandled situation when scan_work appended new namespaces to
ctrl->namespaces and did not sort the list yet.
In such transient state ana_work would fail to match nsids
to those new namespaces.
Both issues potentially caused some namespaces to get stuck
in an incorrect ANA state, e.g. to never become live.
Anton Eidelman (3):
nvme/multipath: fix failure to update ns ana state
nvme/multipath: cosmetic: keep ns nsid locally
nvme/multipath: fix stale ana state for namespaces just added by scan
work
drivers/nvme/host/multipath.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
--
2.25.1
--
*Lightbits Labs**
*Lead the cloud-native data center
transformation by
delivering *scalable *and *efficient *software
defined storage that is
*easy *to consume.
*This message is sent in confidence for the addressee
only. It
may contain legally privileged information. The contents are not
to be
disclosed to anyone other than the addressee. Unauthorized recipients
are
requested to preserve this confidentiality, advise the sender
immediately of
any error in transmission and delete the email from their
systems.*
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-09-12 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 1:07 Anton Eidelman [this message]
2021-09-12 1:07 ` [PATCH 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-12 1:07 ` [PATCH 2/3] nvme/multipath: cosmetic: keep ns nsid locally Anton Eidelman
2021-09-12 1:07 ` [PATCH 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman
2021-09-12 18:49 ` [PATCH 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-12 18:52 ` PLEASE, IGNORE THIS THREAD - BAD FORMATTING Anton Eidelman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210912010731.471859-1-anton@lightbitslabs.com \
--to=anton@lightbitslabs.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).