From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH nvme-cli 1/2] add "State" entry
Date: Thu, 16 Sep 2021 12:21:03 -0700 [thread overview]
Message-ID: <20210916192103.GC3908552@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <74cf36c7-9e18-2b81-08ba-cc4223f3b133@nvidia.com>
On Thu, Sep 16, 2021 at 04:57:55PM +0000, Chaitanya Kulkarni wrote:
> On 9/15/21 6:29 AM, chengjike wrote:
> > From: chengjike <jiangtao62@huawei.com>
> >
> > Add "State" entry in nvme-print.c
> >
> > Signed-off-by: chengjike <chengjike.cheng@huawei.com>
> > ---
> > nvme-print.c | 15 +++++++++------
> > 1 file changed, 9 insertions(+), 6 deletions(-)
> >
> > diff --git a/nvme-print.c b/nvme-print.c
> > index d321ec0..f2b12c0 100644
> > --- a/nvme-print.c
> > +++ b/nvme-print.c
> > @@ -5647,10 +5647,10 @@ static void nvme_show_list_item(nvme_ns_t n)
> > snprintf(format, sizeof(format), "%3.0f %2sB + %2d B", (double)lba,
> > l_suffix, nvme_ns_get_meta_size(n));
> >
> > - printf("%-21s %-20s %-40s %-9d %-26s %-16s %-8s\n",
> > + printf("%-21s %-20s %-40s %-9d %-26s %-16s %-8s %-8s\n",
> > nvme_ns_get_name(n), nvme_ns_get_serial(n),
> > nvme_ns_get_model(n), nvme_ns_get_nsid(n), usage, format,
> > - nvme_ns_get_firmware(n));
> > + nvme_ns_get_firmware(n), nvme_ns_get_state(n));
> > }
> >
>
>
> Where is the definition of the nvme_ns_get_state() ? I didn't find in
> this patch, and your commit log is not helpful at all for the reviewers.
It looks like patch 1 and 2 are reversed.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-16 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 13:29 [PATCH nvme-cli 0/2] add "State" field in command "nvme list" chengjike
2021-09-15 13:29 ` [PATCH nvme-cli 1/2] add "State" entry chengjike
2021-09-16 16:57 ` Chaitanya Kulkarni
2021-09-16 19:21 ` Keith Busch [this message]
2021-09-16 23:01 ` Chaitanya Kulkarni
2021-09-22 13:17 ` Chengjike (ISSP)
2021-09-15 13:29 ` [PATCH nvme-cli 2/2] set disk state chengjike
2021-09-16 16:58 ` [PATCH nvme-cli 0/2] add "State" field in command "nvme list" Chaitanya Kulkarni
2021-09-22 13:11 ` Chengjike (ISSP)
2021-09-19 14:05 ` Sagi Grimberg
2021-09-22 13:01 ` Chengjike (ISSP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916192103.GC3908552@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).