From: Keith Busch <kbusch@kernel.org>
To: "Nikitin, Andrey" <nikitina@amazon.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Buches, Dave" <davebuch@amazon.com>
Subject: Re: [RFC PATCH 0/3] nvme sq associations
Date: Tue, 28 Sep 2021 18:35:54 -0700 [thread overview]
Message-ID: <20210929013554.GA405465@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <79563B18-671F-4654-AE74-7FD9AB5417EF@amazon.com>
On Wed, Sep 29, 2021 at 12:48:49AM +0000, Nikitin, Andrey wrote:
> On 9/25/21, 01:38, "Christoph Hellwig" <hch@infradead.org> wrote:
> >
> > Honestly I'd rather not merge this whole patchset at all. It is a
> > completly frinde feature for a totally misdesigned part of the NVMe
> > spec. Until actual controller in the hands of prosumers support
> > anything like that I'm very reluctant to bloat the driver fast path for
> > it.
>
> Thank you for the feedback.
> While I agree with your remarks regarding feature design in NVMe spec
> the minimal implementation proposed in this patchset would help resolving
> the problems outlined int the original post (undesired queue sharing and
> noisy neighbor).
You still get noisy neighbor with this approach, though: completions
from one set can stall the driver from reaping another set's completions
that were posted earlier.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-29 1:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 0:48 [RFC PATCH 0/3] nvme sq associations Nikitin, Andrey
2021-09-29 1:35 ` Keith Busch [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-24 21:08 Andrey Nikitin
2021-09-25 3:02 ` Keith Busch
2021-09-25 8:31 ` Benjamin Herrenschmidt
2021-09-25 8:36 ` Christoph Hellwig
2021-09-29 6:07 ` Chaitanya Kulkarni
2021-09-29 13:17 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929013554.GA405465@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=davebuch@amazon.com \
--cc=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nikitina@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).